Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of Lucene query parser errors #323

Open
joewiz opened this issue Dec 14, 2017 · 0 comments
Open

Improve handling of Lucene query parser errors #323

joewiz opened this issue Dec 14, 2017 · 0 comments
Labels
Search Lucene or the search module

Comments

@joewiz
Copy link
Member

joewiz commented Dec 14, 2017

Keyword searches that start with an asterisk trigger a stack trace, e.g., https://history.state.gov/search?q=*blah. We should catch Lucene query parser errors and report human-readable error messages:

screen shot 2017-12-14 at 3 17 37 pm

We should probably surround our core queries with try-catch blocks. Ideally we will show the user a useful, actionable error message, but at the very least we should fail more gracefully than this.

See also @plutonik-a's observation in #89 (comment).

@plutonik-a plutonik-a added the Search Lucene or the search module label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search Lucene or the search module
Projects
None yet
Development

No branches or pull requests

2 participants