-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When the hypothesis contained [a @ (b @ c)] where the implicit arguments to [concat] did not match the implicit arguments inferred for [@concat _ _ _ _ a (@concat _ _ _ _ b c)] (according to [pattern]), [left_associate_concat_in] looped, repeatedly finding [a @ (b @ c)], and failing to associate it to the left, introducing constant transports that did nothing. This is now fixed, by picking up and passing the implicit arguments, explicitly. The comment in Modalities/ReflectiveSubuniverse.v has been updated; a naive use of [rewrite@A] causes the subsequent rewrite to fail. I haven't tracked it down, but I suspect @mikeshulman wouldn't have much trouble updating the file. This fixes #744; the test is now added to Tests.v.
- Loading branch information
1 parent
49e31e8
commit 0178072
Showing
3 changed files
with
14 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters