Adapt to coq/coq#13842 #1418
Merged
Adapt to coq/coq#13842 #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seem unrelated |
2 tasks
|
If this is backwards compatible, can we get this merged before the upstream PR? Thanks. |
|
IIUC HoTT CI is currently broken, so we can't be sure this PR is fine? Can't it be tested locally so that it can get merged? I'd like to merge the upstream PR soon but doing so would force you to merge this one right after anyways. |
|
If you want to trust me: I compiled it on my machine and it was fine. |
|
I already checked it locally and approved it, and it's been 2 days, so i think we're good to merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be backward compatible.