-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ObjectClassifier.v and classify maps into BAut. #1524
Conversation
Co-authored-by: Dan Christensen <jdc@uwo.ca>
Co-authored-by: Dan Christensen <jdc@uwo.ca>
LGTM Perhaps we should find a home for ObjectClassifier.v other than just in |
The diff for the changes to |
On github, the split review option in the cog menu at the top seems to be easier to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I need to remember that cog. I wish it were more visible.
I renamed things according to the suggestions, however some of the comments |
@jarlg I think it would be good to update the documentation while we are at it, but if you don't have time just open an issue. |
Alright, I'll do it -- was mostly wondering if the terminology was fine, which I think it is. |
Looks great! |
In the 1st commit, we expand
ObjectClassifier.v
to speak about pointed maps into the universe pointed at some type, and intoType_ O
pointed at someO
-local type. In particular, the former corresponds to the type of fiber sequences, which we may consider to be pointed (equiv_sigma_pfibration
) or not (equiv_sigma_fibration_p
).In the 2nd commit, we view
X => merely (X <~> F)
as a subuniverse to deduce facts about maps intoBAut F
from the statements aboutType_ O
inObjectClassifier.v
. BothpType
andpForall
are made cumulative in order forequiv_pequiv_postcompose
to work at the end ofBAut.v
.Question: in
Truncations/Connectedness.v
we addedconn_to_trunc_ind
, with the naming indicating that this is an induction principle for (n+1)-connected types into n-types. Any suggestions for a better name?Comment: the interest of #1509 is be to make
BAut F
definitionallyType_ O
for the subuniverseX => merely (X = F)
, thus letting us simply specialize results inObjectClassifier.v
toBAut F
. An alternative is to redefineBAut F
to use equivalences, in which caseBAut F
already would beType_ O
definitionally forsubuniverse_merely_equiv
. Having these results will help in determining which approach simplifies things.