Add condition field to AHBLine #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
reviewed
Jun 19, 2024
requirements.in
Outdated
| @@ -1,3 +1,4 @@ | |||
| ahbicht | |||
| attrs>=22.1.0 | |||
There was a problem hiding this comment.
bitte auch in der pyproject.toml ergänzen. edit: ich glaube du brauchst es hier nicht. denn wir nutzen den parser von ahbicht nicht. dann haben wir auch keinen zirkel-bezug zwischen maus und ahbicht
requirements.txt
Outdated
| # maus | ||
| marshmallow-enum==1.5.1 | ||
| # via ahbicht | ||
| maus==0.5.0 |
There was a problem hiding this comment.
erm... wie gehen wir damit um? dass es diese kreis-abhängigkeit gibt @hf-krechan @lord-haffi ?
There was a problem hiding this comment.
@hf-kklein Eine circular dependency ist kein Problem, solange es am Ende keinen circular import gibt.
This reverts commit 1034c1e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for: Hochfrequenz/kohlrahbi#337