🐛 Sanitize ahbNames before comparing them #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
commented
May 2, 2022
| <field name="Codeliste" ref="NAD:2:2" meta.id="3055"/> | ||
| </class> | ||
| <class name="Vorgang" ref="SG4" key="IDE:2:0" max="99999" meta.type="group" groupKey="Vorgangsnummer"> | ||
| <class name="Beteiligter Marktpartner MP-ID" ahbName="Beteiligter Marktpartner MP-ID" ref="SG12" key="NAD:2:0[1:0=VY]" max="99" meta.objType="Marktpartner"> |
There was a problem hiding this comment.
hf-kklein
added a commit
that referenced
this pull request
May 2, 2022
* 🐛 Sanitize ahbNames before comparing them * add 11003 test case * 🐛 Sanitize ahbNames before comparing them (#73) * 🐛 Sanitize ahbNames before comparing them * Fix typing issues by making `make_name_comparable` null safe * relates to Hochfrequenz/edifact-templates#67 * update submodule * add test data to submodule
hf-kklein
added a commit
that referenced
this pull request
May 9, 2022
…8; Adapt Test Structure for VS Code (#61) * 🚚 rename `unittests` ➡ `unit_tests` * add README to unittests dir * add `__init__.py` to unit_tests and update `@pytest.mark.datafiles` paths * fix typos in `tox.ini` * ignore mypy imports in test project * change name of unit test env in Github workflow * Add integration test package * ➕ add private sub module `Hochfrequenz/edifact-templates` * Update unit_tests/README.md Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com> * update submod * add integration test to tox.ini * update integration test readme * add minimal working test * Add integration test workflow * refer to correct secret * wip * use latest submodule * let the fun begin * latest submod * extend tests * udpate test and test data * fix integration test setup * don't ignore errors that's where the fun begins * Allow for yet another weird referencing syntax * Allow for yet another weird referencing syntax * udpate testdata * UTILMD 6063 handling (#65) * UTILMD 6063 handling * minimal modularization * so (#68) * wip * rename * allow EBD G-Listen * better * Allow EBD code lists starting with 'G' (#66) * allow EBD G-Listen * apply pycharm suggestion regarding regex * apply pycharm suggestion regarding regex * black . * add UTILMD 1131 (Fallgruppenzuordnung) Testcase * update templates implies Hochfrequenz/edifact-templates#58 * add UTILMD 1131 (Fallgruppenzuordnung) Testcase (#67) * update sub * modularize * update sub * formatting and stuff * so? * flaaaky. * Add 11002 Test Case and Test Data (#72) * add one more ignore * rename file * add 11002 test case * update submodule * Add 11003 Test Case (#74) * 🐛 Sanitize ahbNames before comparing them * add 11003 test case * 🐛 Sanitize ahbNames before comparing them (#73) * 🐛 Sanitize ahbNames before comparing them * Fix typing issues by making `make_name_comparable` null safe * relates to Hochfrequenz/edifact-templates#67 * update submodule * add test data to submodule * Add EOG (#76) * add eog test file * update submodule and test cases * rename * update to latest sub * Kündigung (#77) * Add Kuendigung Test Cases * rename methods * ignore DTM+Z05/Z06 kündigungstermin * updat esubmodule * update sub * simplify test setup by modularizing the repetetive part (#81) * simplify test setup by modularizing the repetetive part * fix filenotfounderror * Write stricter assertions (#82) * ✨ extend DeepAhb and SegmentGroup with search functions * add failing test * update submodule * fix typos * ✨ Allow searching AHBs for SegmentGroups and Segments (#83) * write an actual test :) * ✅ Make the tests work in vs code (#84) * 🚚 Move unit tests into tests/unit_tests * 🔥 Delete submodule to move it into tests/integrations_tests * 🚚 Move integrations tests into tests/integration_tests * 🔄 Add edifact-templates submodule again * 🔄 Checkout branch 11001 on submodule * ✅ Add fixture which changes the cwd for each test * ⚙️ Update directory for tests in tox.ini * ⚙️ Update paths for mypy checks * 🚚move file after merge * open new branch in submodule * update submodule * update sub, again * Fix MaKo2022 naming confusions by introducing hardcoded names (#89) Asserts fixes of: Maus 11002: Was "OBIS-Kennzahl der Z\u00e4hleinrichtung / Mengenumwerter / Smartmeter-Gateway", expected "OBIS-Kennzahl der Z\u00e4hleinrichtung / Mengenumwerter" edifact-templates#82 Maus 11002/11013: Was "Marktlokation", expected "OBIS-Daten der Marktlokation" edifact-templates#81 Maus 11002: Should be "OBIS Daten f\u00fcr Marktrolle relevant" but was "OBIS Daten f\u00fcr Lieferant relevant"" edifact-templates#80 MAUS 11002: Should be "Druckebene der Marktlokation" but was "Marktlokation" edifact-templates#79 / 11002: Druckebene der Marktlokation edifact-templates#72 11002: Netznutzungsabrechnungsvariante edifact-templates#73 * Prevent Flaky Tests (#90) * prevent flaky tests by using list instead of set because sets (other than dictionaries!) are still unordered https://stackoverflow.com/a/53657523/10009545 * more comments * update submodule * remove unused import * relates to Hochfrequenz/edifact-templates#84 * rename / fix typo Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com> Co-authored-by: kevin <68426071+hf-krechan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.