Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Typing issues #11

Merged
merged 4 commits into from
Mar 8, 2024
Merged

🎨Typing issues #11

merged 4 commits into from
Mar 8, 2024

Conversation

lord-haffi
Copy link
Collaborator

@lord-haffi lord-haffi commented Mar 8, 2024 •
edited
Loading

  • Remove ERRORED
  • Two decorators:
    • decorator leaves return type unchanged
    • decorator_as_result returns a result-object
  • Use generic Protocols with overloaded __call__ signatures to better annotate the decorator
  • Subclass cores Catcher for better typing for the context-manager
  • Catch BaseException instead of Exception

@lord-haffi lord-haffi self-assigned this Mar 8, 2024
hf-kklein
hf-kklein approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lord-haffi lord-haffi merged commit 448d79c into main Mar 8, 2024
15 checks passed
@lord-haffi lord-haffi deleted the modify_typing branch March 8, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-kklein hf-kklein hf-kklein approved these changes

@JonasSchneegans JonasSchneegans Awaiting requested review from JonasSchneegans

Assignees

@lord-haffi lord-haffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lord-haffi @hf-kklein