Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ambush.js #230

Closed
wants to merge 8 commits into from
Closed

Create ambush.js #230

wants to merge 8 commits into from

Conversation

BaneOfAll
Copy link

Well, the code may have a few bugs, but it should work. I need to know how to search in a file for something.

Well, the code may have a few bugs, but it should work. I need to know how to search in a file for something.
@BaneOfAll
Copy link
Author

Just checked the build log and it's nothing to do with this code. It's

TypeError: Cannot read property '404' of undefined
at ClientRequest.onResponse (/home/travis/build/HoeenCoder/Wavelength/node_modules/geoip-lite-country/scripts/updatedb.js:86:97)
at Object.onceWrapper (events.js:315:30)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:558:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:119:17)
at TLSSocket.socketOnData (_http_client.js:454:20)
at emitOne (events.js:116:13)
at TLSSocket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)

@HoeenCoder
Copy link
Owner

Looks like a module is causing issues, would be wise to remove it at this point. Its used in profiles.js. Ill do it later, or you can.

@HoeenCoder
Copy link
Owner

Ok, the crash with the build is fixed, take a look at the error now. I don't have time to review this now, though I assume you created some new globals/used some that don't exist on wavelength. Double check your work (and make sure its tested & works properly, not just that it dosent crash, I will be checking myself).

@HoeenCoder HoeenCoder self-assigned this Mar 22, 2019
@Mystifi
Copy link
Contributor

Mystifi commented Mar 22, 2019

The build error was simply a result of the geoip module returning the same 404 error as addressed in the PR merged earlier today. This code just needs to be updated to reflect those changes and it should work fine after an overall glance.

@Mystifi
Copy link
Contributor

Mystifi commented Mar 22, 2019

I would nonetheless highly recommend a detailed review.

@BaneOfAll
Copy link
Author

Not entirely sure what I'm meant to do @Mystifi @HoeenCoder you told me different things. Is this crash a result of some other pr?

@HoeenCoder
Copy link
Owner

Originally, the build failure was. The issue was fixed in #231 and I re-ran the build. Check this for the list of issues to fix. https://travis-ci.org/HoeenCoder/Wavelength/builds/507729445?utm_source=github_status&utm_medium=notification

@BaneOfAll
Copy link
Author

@HoeenCoder I have finished this finally. Checks passed

@HoeenCoder
Copy link
Owner

On hold at this time, see https://github.com/HoeenCoder/Wavelength/projects and #240

@HoeenCoder HoeenCoder mentioned this pull request Apr 3, 2019
32 tasks
@HoeenCoder HoeenCoder changed the base branch from master to refactor April 3, 2019 17:03
@HoeenCoder
Copy link
Owner

Ok maybe that was a bad idea

@HoeenCoder HoeenCoder changed the base branch from refactor to master April 3, 2019 17:04
@HoeenCoder
Copy link
Owner

We opted to drop this.

@HoeenCoder HoeenCoder closed this Apr 4, 2019
@HoeenCoder HoeenCoder added this to Rejected in Server Refactor Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Server Refactor
  
Removed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants