Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix Disappears after relogin via rdp #307

Closed
Hofknecht opened this issue Feb 4, 2022 · 3 comments
Closed

[BUG] Fix Disappears after relogin via rdp #307

Hofknecht opened this issue Feb 4, 2022 · 3 comments
Assignees
Projects
Milestone

Comments

@Hofknecht
Copy link
Owner

Thank you Nitin for your feedback here:
2022-02-04 14_22_16-Rezensionen

I found maybe the bug or some similar, when relogin via rdp, the menu is not more working and also the notify icon in system tray is missing. So only workaround is to set arg -r or to kill via task manager

it comes from the fact that we restart the STM in the event of a display change in order to apply any dpi changes to the menu.

We have already checked whether we can somehow read out the correct dpi value and compare whether it is really a dpi change, but we have not found anything that works.

So I think it's better to remove the logic for AppRestart.ByDisplaySettings() on SystemEvents_DisplaySettingsChanged. The user can restart himself if dpi changes.

@Hofknecht Hofknecht added this to the 1.3 milestone Feb 4, 2022
@Hofknecht Hofknecht self-assigned this Feb 4, 2022
@Hofknecht Hofknecht added this to Analyze / Spec in STM 1.3.0 via automation Feb 4, 2022
STM 1.3.0 automation moved this from Analyze / Spec to Closed Feb 4, 2022
@vanjac
Copy link

vanjac commented Feb 4, 2022

Would connecting/disconnecting a display also trigger this? I'm not using RDP but the icon keeps disappearing (as of latest update) and I suspect it's caused by switching monitors.

@Hofknecht
Copy link
Owner Author

@vanjac
Thank you for the feedback!
yes, it was restarted at ByDisplaySettings which triggered the issue.
so if you have the same behavior that system tray icon disappeared after monitor change than it is the same.

if you want to you can try latest version (maybe build it via visual studio 2022) and give us feedback if it solved your issue

@vanjac
Copy link

vanjac commented Feb 7, 2022

I just got to try the newest update, and yes, that solved the problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
STM 1.3.0
  
Closed
Development

No branches or pull requests

2 participants