Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Sort method for grouping by file extensions #450

Closed
ppt-oldoerp opened this issue Sep 23, 2022 · 7 comments
Closed

[Feature] Sort method for grouping by file extensions #450

ppt-oldoerp opened this issue Sep 23, 2022 · 7 comments

Comments

@ppt-oldoerp
Copy link

Happy with this tool with one exception: sort order.
In options I set sort order to "Type and Name". I expected type is the windows file extension. I expected all with same extension and inside of them by name. Ongoing for each extension.

I options I also added a folder with xxx.rdp files inside

Sort result seems to ignore type and all are sorted by name:

Windows 11 21H2 build 22000.978
Folder_option
result_list
Files without extension in list are links (Icon on desktop)

Wolfram

@topeterk
Copy link
Collaborator

I checked the code and it looks to me as I remembered it:

            if (Properties.Settings.Default.SortByTypeAndNameWindowsExplorerSort)
            {
                rowDatas = rowDatas.OrderByDescending(x => x.IsFolder)
                    .ThenBy(x => x.Text, new WindowsExplorerSort()).ToList();
            }
            else if (Properties.Settings.Default.SortByTypeAndDate)
            {
                rowDatas = rowDatas.OrderByDescending(x => x.IsFolder)
                    .ThenByDescending(x => x.FileInfo.LastWriteTime).ToList();
            }
            else if (Properties.Settings.Default.SortByName)
            {
                rowDatas = rowDatas.OrderBy(x => x.Text).ToList();
            }
            else if (Properties.Settings.Default.SortByDate)
            {
                rowDatas = rowDatas.OrderByDescending(x => x.FileInfo.LastWriteTime).ToList();
            }

Type is meant to be "folder or file", so the folders are first and then the files are listed. Then each of the two groups are sorted by their names like it is done by WindowsExplorer.

As of today this is by design.

However, it should be not a big deal to add a "grouping" for file extensions as well. I'll turn it into a feature request.

@topeterk topeterk changed the title [BUG] sort wrong with additional folder [Feature] Sort method for grouping by file extensions Sep 23, 2022
@ppt-oldoerp
Copy link
Author

Hi topeterk,

thank you for explain "type" and changing from Bug to Request.
My proposal is in the captions of options to change from "Type" to "Folder" to make it more clear.
Wolfram

@Hofknecht
Copy link
Owner

@ppt-oldoerp
Thank you for the feedback!
we adjusted the text:
2022-10-05 21_55_58-Window

we added you to the Thanks section in readme and about!

We look forward to hearing more from you, please give us further feedback : )

i will close, if something missing, you can reopen or create new one any time

@topeterk
Copy link
Collaborator

topeterk commented Oct 5, 2022

@Hofknecht This issue was not about just a "wrong text" or any "bug". It is about sorting by the files' extension and this updated text does not solve the requested "feature".
Sure, you actually want to close this?
(This implicitly means, a sorting mechanism by file extension will not be implemented)

@Hofknecht
Copy link
Owner

@topeterk
Thanks for the hint, I wasn't quite sure if it was needed.
i added sort by file extension and then by name
see also here in screenshot:
2022-10-06 18_51_21-Window
version 1.3.1.6

@ppt-oldoerp
does that meet your requirements? do you need more? we look forward to further suggestions

@ppt-oldoerp
Copy link
Author

sorry, may be, I have tomato on my eyes - how / whre can I download the 1.3.1.6?
Inbuilt update function says 1.3.1.0 would be latest.
Thank you

@Tanjalibertatis
Copy link
Collaborator

sorry, may be, I have tomato on my eyes - how / whre can I download the 1.3.1.6? Inbuilt update function says 1.3.1.0 would be latest. Thank you

@ppt-oldoerp
That's right, 1.3.1.0 is the latest release version. The feature will be in the next release version (1.3.2.0), not sure when exactly that will be out. To test it earlier, you can download the code and build your own version in Visual Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants