Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony/http-foundation as a direct dependency #9

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

dakur
Copy link
Contributor

@dakur dakur commented Jan 4, 2022

As use cases use Request::METHOD_* constants from symfony/http-foundation (e.g here), it should be listed in direct dependencies. Now it is installed with symplify/easy-coding-standard which is in require-dev section (not suitable for production).

@Holicz
Copy link
Owner

Holicz commented Jan 4, 2022

Great eye, thank you

@Holicz Holicz merged commit ebc8fc8 into Holicz:main Jan 4, 2022
@dakur
Copy link
Contributor Author

dakur commented Jan 4, 2022

Great eye, thank you

Well, it just did not work that's how I found it. 😁

@dakur dakur deleted the symfony-http-foundation-dep branch January 4, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants