Add __clone method, increase loss to 10 %

Holicz · Mar 30, 2020 · d35da25 · d35da25
1 parent 9ea384d
commit d35da25
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Adapter/PvgisAdapter.php b/src/Adapter/PvgisAdapter.php
@@ -13,7 +13,7 @@
 
 final class PvgisAdapter
 {
-    private const API_URL = 'https://re.jrc.ec.europa.eu/api/pvcalc?peakpower=1&pvtechchoice=crystSi&mountingplace=building&loss=1&outputformat=json&angle=35&lat=%s&lon=%s';
+    private const API_URL = 'https://re.jrc.ec.europa.eu/api/pvcalc?peakpower=1&pvtechchoice=crystSi&mountingplace=building&loss=10&outputformat=json&angle=35&lat=%s&lon=%s';
 
     /**
      * Multiplier to change the PVGIS result in order to get desired production
@@ -60,7 +60,7 @@ private function parsePvgisResponse(string $response): ElectricityProduction
         try {
             $response = json_decode($response, true, 512, JSON_THROW_ON_ERROR);
 
-            $electricityProduction = new ElectricityProduction($this->multiplier * $response['outputs']['totals']['fixed']['E_m']);
+            $electricityProduction = new ElectricityProduction($this->multiplier * $response['outputs']['totals']['fixed']['E_y']);
             foreach ($response['outputs']['monthly']['fixed'] as $month) {
                 $electricityProduction->addMonthlyProduction($month['month'], $this->multiplier * $month['E_m']);
             }

diff --git a/src/Model/ElectricityProduction.php b/src/Model/ElectricityProduction.php
@@ -15,6 +15,16 @@ public function __construct(float $yearlyProduction)
         $this->yearlyProduction = $yearlyProduction;
     }
 
+    public function __clone()
+    {
+        $monthlyProductions = [];
+        foreach ($this->monthlyProductions as $monthlyProduction) {
+            $monthlyProductions[] = clone $monthlyProduction;
+        }
+
+        $this->monthlyProductions = $monthlyProductions;
+    }
+
     public function addMonthlyProduction(int $month, float $production): self
     {
         $this->monthlyProductions[] = new MonthlyProduction($month, $production);