Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to yarn #108

Merged
merged 1 commit into from Mar 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions .travis.yml
Expand Up @@ -24,14 +24,10 @@ addons:
- xvfb
notifications:
email: false
cache:
directories:
- node_modules
- packages/holly/node_modules
- packages/holly-ui/node_modules
cache: yarn
script:
- "npx lerna bootstrap"
- "npm run ci"
- "yarn"
- "yarn ci"
jobs:
include:
- node_js: "12"
Expand Down
26 changes: 13 additions & 13 deletions CONTRIBUTING.md
@@ -1,16 +1,7 @@
# Dev Setup

```
npm i
npx lerna bootstrap
```

Note: you may get some problems with `npm install` so you can run alternatively:

```
npm i
npx lerna exec npm i
npx lerna link
yarn
```

# Testing changes to open
Expand All @@ -19,21 +10,30 @@ First build and watch the ui by running this in packages/holly-ui

```
cd packages/holly-ui
npm run start
yarn start
```

Then in a different terminal, watch for server changes in packages/holly

```
cd packages/holly
npm run build:watch
yarn build:watch
```

Either build the shared package or watch it if you plan on making changes:

```
cd packages/holly-shared
yarn build:watch
```

In a different terminal you can start an instance of holly that the ui will connect to:

```
cd packages/holly
npm run test:passes:open
yarn test:passes:open
```

and now the UI will connect to it and show a list of the specs from the passes folder.

If you make changes to the server, stop the `yarn test:passes:open` and restart it. The website will reconnect.
8 changes: 4 additions & 4 deletions lerna.json
@@ -1,6 +1,6 @@
{
"packages": [
"packages/*"
],
"version": "0.0.1"
"npmClient": "yarn",
"packages": ["packages/*"],
"version": "0.0.1",
"useWorkspaces": true
}