Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#70] Use qualified imports for Types module #85

Merged
merged 3 commits into from Sep 4, 2019
Merged

[#70] Use qualified imports for Types module #85

merged 3 commits into from Sep 4, 2019

Conversation

vrom911
Copy link
Contributor

@vrom911 vrom911 commented Sep 3, 2019

Resolves #70

@vrom911 vrom911 added enhancement New feature or request pretty printing labels Sep 3, 2019
@vrom911 vrom911 self-assigned this Sep 3, 2019
chshersh
chshersh approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I wonder, should we add one more custom data type with conflicting names to test this? Like:

data Result = Ok | Error Text

@vrom911
Copy link
Contributor Author

vrom911 commented Sep 3, 2019

Nice idea! I will try that!

@vrom911 vrom911 force-pushed the vrom911/70-Clashing-constructors branch from 194de88 to 9cf7f60 Compare September 4, 2019 04:06
@vrom911
Copy link
Contributor Author

vrom911 commented Sep 4, 2019

Updated.

@chshersh chshersh merged commit 7a73918 into master Sep 4, 2019
@chshersh chshersh deleted the vrom911/70-Clashing-constructors branch September 4, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
enhancement New feature or request pretty printing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clashing constructors
2 participants
@vrom911 @chshersh