Implement metadata handling #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JettTech
approved these changes
Nov 6, 2020
| // { | ||
| // type: 'success', | ||
| // payload: 'I am a werewolf', | ||
| // metadata: { |
There was a problem hiding this comment.
Are we expecting the response_id to be included in the metadata as a standard now? If so, can we add an example of the response_id being included here?
There was a problem hiding this comment.
No, the data-translator is a general-use translator, the response_id is implementation-specific between Chaperone and Envoy.
Comment on lines
+156
to
+161
| if ( arguments.length === 2 ) { | ||
| if ( value === undefined ) { | ||
| const previous_value = this._metadata[key]; | ||
| delete this._metadata[key]; | ||
| return previous_value; | ||
| } |
There was a problem hiding this comment.
Can you put this into context for me? When might the metadata return without a value, and why how do we know it's response_id will be/should be the exact same?
There was a problem hiding this comment.
I don't fully understand the question. The metadata value is always returned, but the value may have been set to undefined (via delete)
Co-authored-by: Lisa Jetton <lisa.jetton@holo.host>
Co-authored-by: Lisa Jetton <lisa.jetton@holo.host>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
metadata( key, value? )method to get/set package metadata