Skip to content
This repository has been archived by the owner on Feb 22, 2021. It is now read-only.

per-feed expire time #125

Closed
ildar opened this issue Apr 19, 2014 · 20 comments
Closed

per-feed expire time #125

ildar opened this issue Apr 19, 2014 · 20 comments

Comments

@ildar
Copy link

ildar commented Apr 19, 2014

I have almost 10000 items. That's slow 😠
Looking at my feeds I see that along with usual news feeds injecting lots of items I also have some oldish small feeds to read later.
So for me there's no good choice for "Time interval to keep entries".
To fix this there may be a per-feed setting or
another way to limit entries pollution: by number of entries
What do you think?

@deoren
Copy link

deoren commented Apr 30, 2014

+1

@ildar
Copy link
Author

ildar commented Jun 3, 2014

​Also, I started to dig the FeedEx.db and found that date (and prbably
fetch_date) are non-standard format in terms of SQLite:
sqlite> select date from entries where feedid=7;
1369383485000
1369894874000
sqlite> select date(date) from entries where feedid=7;
1698789-19650109-20
1698789-19650109-20
sqlite> select date('now') from entries where feedid=7;
2014-06-03
2014-06-03

I wanted to clean my DB manually but seem to stuck. :(

@Urban82
Copy link
Contributor

Urban82 commented Jun 3, 2014

Hi, the value in the DB is just a unix timestamp with milliseconds (a standard date/time format in many languages, including java!)

in a unix/linux box you can convert it removing the trailing 000 and using the date command as this:
$ date -d '@1369383485'
ven 24 mag 2013, 10.18.05, CEST

@ildar
Copy link
Author

ildar commented Jun 4, 2014

@Urban82, thanks and you are right.

So the workaround for this issue:
0. Get into the DB:
sqlite3 /data/data/net.fred.feedex/databases/FeedEx.db

  1. Get entries number per feed:
    select feedid,count (*) from entries group by feedid order by count (*);
  2. Delete entries older then 2 month that aren't in favorites for
    feedid=FEEDID(substitute):
    delete from entries where favorite is null and datetime(date/1000,'unixepoch') < datetime('now','-2 month') and feedid=FEEDID;

@myrdd
Copy link

myrdd commented Aug 1, 2014

+1

@FredJul FredJul closed this as completed Jul 4, 2018
@ildar
Copy link
Author

ildar commented Aug 18, 2018 via email

@ildar
Copy link
Author

ildar commented Aug 18, 2018 via email

@ildar
Copy link
Author

ildar commented Aug 31, 2018 via email

@myrdd
Copy link

myrdd commented Aug 31, 2018

@FredJul any comment on why you closed this issue?
@ildar what about working on a PR on your own?

@ildar
Copy link
Author

ildar commented Aug 31, 2018 via email

@FredJul
Copy link
Owner

FredJul commented Aug 31, 2018

I actually closed all previous issues, the was a lot of fake issues for some pills advertising at that time and since the v2 codebase is totally new some of the previous tickets were obsoletes. So I prefered to start again from a fresh start.

And concerning this issue in particular, I actually wonder if the problem still exists in v2, I believe I have fixed one problem which could help that.

@ildar
Copy link
Author

ildar commented Aug 31, 2018 via email

@FredJul
Copy link
Owner

FredJul commented Aug 31, 2018

It was not a recent fix, I did it during the v2 rework.

Today I don't really want to add a time limit per feed. I prefer to keep Flym simple, I have more important feature to do before, and if you want to keep one particular entry, you can still star it. But I believe there was a problem leading to some never-deleted entries in the v1 codebase.

Before reopening this issue I would like to know if people actually still encounter a performance degradation over time. Of course if they decided to select "always" in the time conservation setting then I expect it to be slower and slower. I actually should maybe delete that "always" possibility.

@ildar
Copy link
Author

ildar commented Aug 31, 2018 via email

@ildar
Copy link
Author

ildar commented Sep 5, 2018 via email

@FredJul
Copy link
Owner

FredJul commented Sep 5, 2018

Glad to see you like it!

I understand your previous critics on the UX, even if I disagree for some. But please note that I plan to add back some previous features little by little (light theme, compact view for the lists, sort order setting...). It's just that it's hard to find the time for that.

@ildar
Copy link
Author

ildar commented Sep 5, 2018 via email

@FredJul
Copy link
Owner

FredJul commented Sep 5, 2018

Reopen this particular issue about per-feed expire time? I'm still not convince on that one, I still believe it will make the UI and the code more complex for a not-so-common use case. One thing is sure: it is not my priority, but if other people manifests their interest or if someone want to code it, then I guess I'm not against it.

And about the UX, sorry I actually misunderstood your previous sentence: "And soon I'll check if Flym v2 (hopefully) show better UX."

@ildar
Copy link
Author

ildar commented Sep 5, 2018 via email

@Lachmoewe
Copy link

My usecase is also that I have a few news sites punching out news by the minute, and then something like rubikon with only a few articles per month. In order to save space on my phone I had to set the delete time to four days, rendering it impossible to read the slower news sites. Having a per feed or even per folder delete time would help me a lot with this. I guess it wouldnt really complicate the UI if you put a tick box in the feed settings menu with something like "custom delete time", with greyed out time setting if not ticked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants