Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override login when cookie files are not expired #34

Closed
mirusu400 opened this issue Jan 16, 2022 · 7 comments
Closed

Override login when cookie files are not expired #34

mirusu400 opened this issue Jan 16, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mirusu400
Copy link
Contributor

Is your feature request related to a problem? Please describe.
About login / cookie

Describe the solution you'd like
Check the cookie is expired, and if the cookie is not expired, not login

Additional context

twspace_dl.py -U https://twitter.com/[user] --input-cookie-file cookie.txt login -u [username] -p [password] -o cookie.txt

When I run script like this, twspace-dl only gets a cookie, and not download twitter space. As I reffered #27, we need to check cookie file first, and it exists and not expired, skip login and trying to get and download twitter space.

This method will be better when run as Docker or Service (We can run as only one commands).

@mirusu400 mirusu400 added the enhancement New feature or request label Jan 16, 2022
@Ryu1845
Copy link
Collaborator

Ryu1845 commented Jan 16, 2022

I see but this would only work with accounts without 2fa hmm

@mirusu400
Copy link
Contributor Author

I think 2FA doesn't matter; If they run this program as service or docker, just recommend to use alternative account without 2fa. All we do is just warn on README.

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Jan 17, 2022

Fair enough I guess. I'll try to do that asap

@qkum
Copy link

qkum commented Jan 17, 2022

I think 2FA doesn't matter; If they run this program as service or docker, just recommend to use alternative account without 2fa. All we do is just warn on README.

Yeah, you should not use your main Twitter account for this anyway.

  1. You could get banned in the worst case on your main account.
  2. Twitter thinks your hacked.
  3. Basic IT security practice - Don't let code you have not coded run your main accounts (there could be hidden backdoors in the code. Maybe the repo gets hacked and when you update the program - you get hacked etc.)

@qkum
Copy link

qkum commented Jan 17, 2022

All you need for a new Twitter account is a phone number if I'm not wrong.

Better use 10-20 USD on that than getting hacked or banned.

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Jan 17, 2022

You can get an sms for way cheaper than that but it'd be a temporary number

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Feb 18, 2022

Long overdue but done in latest release

@Ryu1845 Ryu1845 closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants