Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual login class #27

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Add manual login class #27

merged 2 commits into from
Jan 3, 2022

Conversation

mirusu400
Copy link
Contributor

@mirusu400 mirusu400 commented Jan 2, 2022

I just made a simple object about getting auth_token by using your username(id) and password.

It may be useful when the token expire, I just do this PR for future.

@Ryu1845 Ryu1845 linked an issue Jan 2, 2022 that may be closed by this pull request
@Ryu1845
Copy link
Collaborator

Ryu1845 commented Jan 2, 2022

I'll modify some stuff first before merging if you're ok with them.

  1. instead of calling the script directly, do it from the main one(i.e. --login)
  2. change some variable and function names to make it more self-documenting
  3. Add cookie file support but that's less important and in the scope of this PR

@mirusu400
Copy link
Contributor Author

I'll modify some stuff first before merging if you're ok with them.

  1. instead of calling the script directly, do it from the main one(i.e. --login)
  2. change some variable and function names to make it more self-documenting
  3. Add cookie file support but that's less important and in the scope of this PR

Sure

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor Author

@mirusu400 mirusu400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

04f1dfa#diff-156492a8cc62084db785c62dac5327a5b14f0889c2d2f05f5aab8b7610000b8dR80-R95

When we login too much in a time, twitter blocks a account temporary and check more auths. It may cause error when run as service or docker (cause it runs every 15 secs or 30 secs).

It should be better to save auth_token to file and check manually if the auth_token expire and then trying to login and get auth_token

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Jan 3, 2022

I think I'm gonna export it to a cookie file so I might as well to the input at the same time. I'll open a new pr for that and consider this one done if you're ok with that

@mirusu400
Copy link
Contributor Author

I think I'm gonna export it to a cookie file so I might as well to the input at the same time. I'll open a new pr for that and consider this one done if you're ok with that

Then your commit looks nice 👍 I think it can be merged

@Ryu1845 Ryu1845 merged commit dc38028 into HoloArchivists:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add login method to parse space links
2 participants