Support for Windows with msvc #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As M_PI is non-standard macro, msvc does not support M_PI in cmath. For defining M_PI, add _USE_MATH_DEFINES macro in advance
In msvc, this is not permitted conversion. As std::filesystem::path provides string() method, I replaced it.
replace WINDOWS to _WIN32 for checking botn window 32bit and 64bit. I think WINDOWS is not valid for checking window platform
As non-constant size array declaration is non-standard, I replaced it to vector
As, vector.reserve actually not allocating memory, in my compiler these commands make abort. I think reserve calls need to be replaced by resize or constructor with size.
As a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax, I remove explicit type conversion because both left and right are same type I think there is no need to specifying it.
without this binary flag (e.g. with text mode), vkCreateShaderModule function does not work properly. I added this flag and work project completely good in window
|
Thanks for the PR. It's great to see these fixes. I'll do a quick review and we'll accept the changes. Also thanks for the issues in windows. I will investigate some fixes. |
gpx1000
approved these changes
Mar 17, 2021
| @@ -137,9 +137,9 @@ namespace Util { | |||
| return false; | |||
| } | |||
|
|
|||
| XrReferenceSpaceType referenceSpaces[referenceSpacesCount]; | |||
There was a problem hiding this comment.
Moving to C++ vectors from C Arrays is fine for me. I initially wanted to keep them as C Arrays as this is meant as an instructional sample rather than a production code. I think this is a fine change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. At first, I really appreciated for providing really good example of openxr and vulkan application.
But I encountered problem with build error in Windows msvc compiler
I modified some codes for supporting window platform as far as not touching Linux specific codes.
In addition, there is trivial problems like below
program complains about there is no ktx.dll file. Thus, I did manually relocate ktx.dll file to executable file path.