Noisemaker Scrap Type Fix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the syncUseFunction flag to true for the NoisemakerProp, this allows the Noisemaker to activate and be replicated across clients. I also added the ability to leave the fields in the SDK for noiseAudio and noiseAudioFar blank and have added close-to-game AudioSources. Also reordered the way the grab/drop Audiosource is added, since GetComponent grabs the 'top' Audiosource, so the grab/drop Audiosource should be first when added.
Makes the close audio of the Noisemaker Diegetic.
|
Hello, I don't have the time to test this PR |
|
I would definitely be interested in contributing, I don't know how much of a successor I could be since I am fairly new to modding, but I could likely try to keep the mod up-to-date and carry on the project in that sense! If you want to connect my discord is singular_jame. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue with the Noisemaker scrap type where other players could not hear the Noisemaker on their side, it appeared to only be client side. This was mainly fixed by ensuring the syncUseFunction attribute was marked true.
I've also reworked some of the Noisemaker scrap type logic, so now developers in the SDK no longer need to specify noiseAudio and noiseAudioFar, as they will be generated automatically.
Along with that, I reordered the grab/drop Audiosource to the beginning of scrap creation so that GetComponent grabs the right when in the game's code. I also slightly modified Terminal_Path.cs to make noiseAudio Diegetic.
Some of the other scrap types could probably use similar fixes, but I thought I would go ahead and fix one of them to not change anything too drastically.