Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes on capabilities: #107

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fixes on capabilities: #107

merged 1 commit into from
Apr 8, 2022

Conversation

aturri
Copy link
Contributor

@aturri aturri commented Feb 21, 2022

  • check that signaInfo, signalDoor, signalFailure are supported by device type
  • add sensors for drying step (tumble dryer), spinning speed (washer), program phase
  • check water/energy sub capability on ecofeedback (tumble dryer has no water consumption)

@aturri
fixes on capabilities:
216a215 
- check that signaInfo, signalDoor, signalFailure are supported by device type
- add sensors for drying step (tumble dryer), spinning speed (washer), program phase
- check water/energy sub capability on ecofeedback (tumble dryer has no water consumption)
@kloknibor
Copy link
Contributor

The capabilities list from Miele is far from complete. Some of the same sort of devices even have different capabilities. Because of this I'm not sure if I'm in favor of merging this PR. Although I'm open to discussion.

@aturri
Copy link
Contributor Author

aturri commented Mar 4, 2022

Hi, thank you for your answer.
We could support signal info, door, failure for all types of devices.
However, spinning speed, program phase and drying step should be supported according to Miele specs.
I also removed water consumption for tumble dryer because it makes no sense, even if Miele has only a generic capability called “eco feedback”.
What do you think?

@kloknibor kloknibor merged commit 700825e into HomeAssistant-Mods:dev Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
@kloknibor @github-actions
Merge pull request #107 from aturri/dev
3c622d2 
fixes on capabilities:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aturri @kloknibor