Fix oauth behind a reverse proxy #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oauth url should be generated with home assistant external_access url (public domain/IP) if available. This allow the integration to correctly get the oauth token when Home Assistant is behind a reverse proxy and an external url has been set in HA settings. Rollback to internal_access url (private domain/IP) if none external url exist.
catadiel
changed the title
|
Thanks! Sorry for the late merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oauth url should be generated with home assistant external_access url (public domain/IP) if available.
This allow the integration to correctly get the oauth token when Home Assistant is behind a reverse proxy and an external url has been set in HA settings.
Rollback to internal_access url (private domain/IP) if none external url exist.
This substitute #61 with requested dev branch base