Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProgramID #9

Merged
merged 6 commits into from Dec 21, 2020
Merged

add ProgramID #9

merged 6 commits into from Dec 21, 2020

Conversation

SteffenWilberg
Copy link
Contributor

ProgramID is listed correctly in the „Dishwasher Status“ card, e.g. „Economy“.
But the added „Dishwasher Program ID“ sensor shows the same as „Dishwasher Status“, e.g. the same text „Program Selected“ and the same card as „Dishwaser Status“.

@SteffenWilberg
Copy link
Contributor Author

Fixed it. I‘m happy with the new ProgramID text sensor.
I could remove it from the status card again, as that‘s redundant.

@kloknibor
Copy link
Contributor

I will try to review this commit later today. Thanks for your input anyway!

@kloknibor
Copy link
Contributor

Seems ok, but can you rederict your PR to the dev repo for now? Instruction on how to do it can be found here : https://github.blog/2016-08-15-change-the-base-branch-of-a-pull-request/

I will just check there if everything keep running smoothly and than Merge to the master later. Thanks!

@SteffenWilberg SteffenWilberg changed the base branch from master to dev December 17, 2020 00:17
@kloknibor kloknibor merged commit 27a17ab into HomeAssistant-Mods:dev Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants