Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust token usage #14

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Adjust token usage #14

merged 1 commit into from
Apr 6, 2021

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Apr 6, 2021

  • Use new HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN for creating pull requests as @BrewTestBot
  • Use GITHUB_TOKEN for locking/closing/commenting (which will change comments from @BrewTestBot to the GitHub Actions bot but is worth the reduction in access permissions and number of repositories that need HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN)

Also, while we're here, let my editor autocorrect the YAML formatting.

- Use new `HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN` for creating pull requests
  as @BrewTestBot
- Use `GITHUB_TOKEN` for locking/closing/commenting (which will change
  comments from @BrewTestBot to the GitHub Actions bot but is worth the
  reduction in access permissions and number of repositories that need
  `HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN`)

Also, while we're here, let my editor autocorrect the YAML formatting.
@MikeMcQuaid MikeMcQuaid changed the title Use new HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN Adjust token usage Apr 6, 2021
@MikeMcQuaid MikeMcQuaid merged commit a8187c2 into master Apr 6, 2021
@MikeMcQuaid MikeMcQuaid deleted the public_repo_token branch April 6, 2021 12:23
@Rylan12
Copy link
Member

Rylan12 commented Apr 6, 2021

Looks like the sync PRs didn't work here:

   ! [remote rejected] HEAD -> sync-triage-config (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/triage-issues.yml` without `workflow` scope)

Looks like the token to create the PRs needs workflow, too.

@MikeMcQuaid
Copy link
Member Author

@Rylan12 Yup, adding a new token for that 👍🏻

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants