Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-disabled-packages: add action #555

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Jun 17, 2024

This PR adds a modified version of the existing remove-disabled-formulae action that would work across both homebrew-core and homebrew-cask, and be useable in a repository that includes both Formula and Casks.

It may be worthwhile adding an additional feature to pass a variable for the amount of months a package should be disabled before being removed, as there may be a difference in process between homebrew-core and homebrew-cask.

MikeMcQuaid
MikeMcQuaid previously approved these changes Jun 17, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bevanjkay! Could you run brew style --fix over the Ruby here, too?

remove-disabled-packages/action.yml Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member Author

This now passes style checks for this directory locally

brew style --fix remove-disabled-packages
Inspecting 2 files
..

2 files inspected, no offenses detected

and is also still functional, tested on my own tap.

@MikeMcQuaid MikeMcQuaid merged commit 68fa6ae into Homebrew:master Jun 17, 2024
3 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @bevanjkay!

@Bo98
Copy link
Member

Bo98 commented Jun 18, 2024

Can you change homebrew-core to use this and delete remove-disabled-formulae entirely? Seems like we're the only user beyond some homebrew-core forks (which are their responsibility to rebase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants