setup-homebrew: update tweaks. #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
reviewed
Jul 5, 2023
carlocab
reviewed
Jul 5, 2023
Should already be I think. homebrew-core in general is a special case in this script. Except the test-bot bit but I've commented on that above. |
MikeMcQuaid
force-pushed
the
update_tweaks
branch
from
63a0af2
to
3edce1b
Compare
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jul 5, 2023
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
Bo98
reviewed
Jul 5, 2023
MikeMcQuaid
force-pushed
the
update_tweaks
branch
2 times, most recently
from
7b06819
to
2bd38cf
Compare
Bo98
reviewed
Jul 5, 2023
carlocab
approved these changes
Jul 5, 2023
carlocab
reviewed
Jul 5, 2023
Bo98
reviewed
Jul 5, 2023
MikeMcQuaid
force-pushed
the
update_tweaks
branch
from
2bd38cf
to
7fdc0b2
Compare
carlocab
added a commit
to carlocab/homebrew-test-bot
that referenced
this pull request
Jul 6, 2023
See discussion at Homebrew/actions#393.
|
carlocab
added a commit
to carlocab/homebrew-test-bot
that referenced
this pull request
Jul 6, 2023
See discussion at Homebrew/actions#393.
Bo98
reviewed
Jul 6, 2023
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jul 6, 2023
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
force-pushed
the
update_tweaks
branch
from
7fdc0b2
to
9f9f684
Compare
Bo98
reviewed
Jul 6, 2023
- don't update core/cask/test-bot by default - unset HOMEBREW_NO_INSTALL_FROM_API (which GitHub Actions sets by default - use `brew update` to download formula/cask files Co-authored-by: Bo Anderson <mail@boanderson.me>
MikeMcQuaid
force-pushed
the
update_tweaks
branch
from
9f9f684
to
f9eb51b
Compare
Bo98
approved these changes
Jul 6, 2023
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jul 6, 2023
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jul 6, 2023
Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
added a commit
to Homebrew/homebrew-cask
that referenced
this pull request
Jul 6, 2023
Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jul 6, 2023
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
added a commit
to Homebrew/brew
that referenced
this pull request
Jul 6, 2023
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew updateto download formula/cask filesIf this is ✅: we'll need to audit our usage of this action to ensure they are configured correctly to allow this change but it should reduce load on GitHub, failures seen by us and our users and better test the default Homebrew setup.