Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused actions #517

Merged
merged 6 commits into from
Apr 6, 2024
Merged

Remove unused actions #517

merged 6 commits into from
Apr 6, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 29, 2024

I've been working on a complete testing overhaul here, but there's some actions that feel like wasted effort to try include in that overhaul.

Open for discussion - happy to do a deprecation path for some of these, however that is supposed to look like. Only cancel-previous-runs was previously marked "deprecated".

For all, I did best effort searches for existing usage, but this is limited to repositories indexed by GitHub and also does not include private or enterprise repositories. If we do end up removing anything anyone uses, I'd invite them to let us know and we can figure something out. Each are individual commits that can be independently reverted.

github-actions[bot]
github-actions bot previously approved these changes Mar 29, 2024
Copy link

body

@github-actions github-actions bot added wontfix This will not be worked on invalid This doesn't seem right and removed wontfix This will not be worked on invalid This doesn't seem right labels Mar 29, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on removal and thanks for cleanup. 👍🏻 to just merge this and we can consider re-adding and deprecating individual items if there are complaints.

@Bo98 Bo98 merged commit 48cced7 into master Apr 6, 2024
18 checks passed
@Bo98 Bo98 deleted the cleanup branch April 6, 2024 01:15
Comment on lines -60 to -62
uses: Homebrew/actions/count-bottles@master
with:
working-directory: ${{ inputs.bottles-directory }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caused some issue

Error: Homebrew/actions/master/post-build/action.yml: (Line: 60, Col: 57, Idx: 1765) - (Line: 60, Col: 78, Idx: 1786): While parsing a block mapping, did not find expected key.
Error: System.ArgumentException: Unexpected type '' encountered while reading 'action manifest root'. The type 'MappingToken' was expected.
   at GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertMapping(TemplateToken value, String objectDescription)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load Homebrew/actions/master/post-build/action.yml

https://github.com/Homebrew/homebrew-core/actions/runs/8577932249/job/23511213925?pr=168176

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants