codesign in keg_relocate instead of keg methods

Currently the codesign_patched_binary method may be called many
times for the same file when installing a keg.

This removes the calls to codesign_patched_binary from os/mac/keg
and adds a single call to the relocate_dynamic_linkage and
fix_dynamic_linkage methods in extend/os/mac/keg_relocate
to speed up keg installation.

Library/Homebrew/extend/os/mac/keg_relocate.rb

@@ -35,6 +35,9 @@ def relocate_dynamic_linkage(relocation)
           new_name = relocated_name_for(old_name, relocation)
           change_rpath(old_name, new_name, file) if new_name
         end
+
+        # codesign the file once after other steps
+        codesign_patched_binary(file)
       end
     end
   end
@@ -71,6 +74,9 @@ def fix_dynamic_linkage
 
           delete_rpath(bad_name, file)
         end
+
+        # codesign the file once after other steps
+        codesign_patched_binary(file)
       end
     end
 

Library/Homebrew/os/mac/keg.rb

@@ -8,7 +8,6 @@ def change_dylib_id(id, file)
     @require_relocation = true
     odebug "Changing dylib ID of #{file}\n  from #{file.dylib_id}\n    to #{id}"
     file.change_dylib_id(id, strict: false)
-    codesign_patched_binary(file)
   rescue MachO::MachOError
     onoe <<~EOS
       Failed changing dylib ID of #{file}
@@ -24,7 +23,6 @@ def change_install_name(old, new, file)
     @require_relocation = true
     odebug "Changing install name in #{file}\n  from #{old}\n    to #{new}"
     file.change_install_name(old, new, strict: false)
-    codesign_patched_binary(file)
   rescue MachO::MachOError
     onoe <<~EOS
       Failed changing install name in #{file}
@@ -40,7 +38,6 @@ def change_rpath(old, new, file)
     @require_relocation = true
     odebug "Changing rpath in #{file}\n  from #{old}\n    to #{new}"
     file.change_rpath(old, new, strict: false)
-    codesign_patched_binary(file)
   rescue MachO::MachOError
     onoe <<~EOS
       Failed changing rpath in #{file}
@@ -53,7 +50,6 @@ def change_rpath(old, new, file)
   def delete_rpath(rpath, file)
     odebug "Deleting rpath #{rpath} in #{file}"
     file.delete_rpath(rpath, strict: false)
-    codesign_patched_binary(file)
   rescue MachO::MachOError
     onoe <<~EOS
       Failed deleting rpath #{rpath} in #{file}