Merge pull request #10910 from Bo98/upgrade-dry-run

cmd/upgrade: fix --dry-run
Homebrew · Mar 23, 2021 · 52c6faf · 52c6faf
2 parents 3c6a7b3 + 3bf38a1
commit 52c6faf
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb
@@ -174,19 +174,21 @@ def upgrade_outdated_formulae(formulae, args:)
       puts formulae_upgrades.join("\n")
     end
 
-    Upgrade.upgrade_formulae(
-      formulae_to_install,
-      flags:                      args.flags_only,
-      installed_on_request:       args.named.present?,
-      force_bottle:               args.force_bottle?,
-      build_from_source_formulae: args.build_from_source_formulae,
-      interactive:                args.interactive?,
-      keep_tmp:                   args.keep_tmp?,
-      force:                      args.force?,
-      debug:                      args.debug?,
-      quiet:                      args.quiet?,
-      verbose:                    args.verbose?,
-    )
+    unless args.dry_run?
+      Upgrade.upgrade_formulae(
+        formulae_to_install,
+        flags:                      args.flags_only,
+        installed_on_request:       args.named.present?,
+        force_bottle:               args.force_bottle?,
+        build_from_source_formulae: args.build_from_source_formulae,
+        interactive:                args.interactive?,
+        keep_tmp:                   args.keep_tmp?,
+        force:                      args.force?,
+        debug:                      args.debug?,
+        quiet:                      args.quiet?,
+        verbose:                    args.verbose?,
+      )
+    end
 
     Upgrade.check_installed_dependents(
       formulae_to_install,