Merge pull request #12971 from Homebrew/dependabot/bundler/Library/Ho…

…mebrew/rubocop-performance-1.13.3 build(deps): bump rubocop-performance from 1.13.2 to 1.13.3 in /Library/Homebrew
Homebrew · Mar 8, 2022 · 5f044f0 · 5f044f0
2 parents 6c7dd00 + 7f1a208
commit 5f044f0
Show file tree

Hide file tree

Showing 61 changed files with 14 additions and 20 deletions.
diff --git a/Library/Homebrew/Gemfile.lock b/Library/Homebrew/Gemfile.lock
@@ -134,7 +134,7 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.16.0)
       parser (>= 3.1.1.0)
-    rubocop-performance (1.13.2)
+    rubocop-performance (1.13.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.13.2)

diff --git a/...t/rbi/gems/rubocop-performance@1.13.2.rbi → ...t/rbi/gems/rubocop-performance@1.13.3.rbi b/...t/rbi/gems/rubocop-performance@1.13.2.rbi → ...t/rbi/gems/rubocop-performance@1.13.3.rbi
diff --git a/Library/Homebrew/vendor/bundle/bundler/setup.rb b/Library/Homebrew/vendor/bundle/bundler/setup.rb
@@ -85,7 +85,7 @@
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/ruby-progressbar-1.11.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/unicode-display_width-2.1.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-1.25.1/lib"
-$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.13.2/lib"
+$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.13.3/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rails-2.13.2/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rspec-2.9.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-sorbet-0.6.7/lib"

diff --git a/...cop-performance-1.13.2/config/default.yml → ...cop-performance-1.13.3/config/default.yml b/...cop-performance-1.13.2/config/default.yml → ...cop-performance-1.13.3/config/default.yml
diff --git a/...-performance-1.13.2/config/obsoletion.yml → ...-performance-1.13.3/config/obsoletion.yml b/...-performance-1.13.2/config/obsoletion.yml → ...-performance-1.13.3/config/obsoletion.yml
diff --git a/...ormance-1.13.2/lib/rubocop-performance.rb → ...ormance-1.13.3/lib/rubocop-performance.rb b/...ormance-1.13.2/lib/rubocop-performance.rb → ...ormance-1.13.3/lib/rubocop-performance.rb
diff --git a/...rubocop/cop/mixin/regexp_metacharacter.rb → ...rubocop/cop/mixin/regexp_metacharacter.rb b/...rubocop/cop/mixin/regexp_metacharacter.rb → ...rubocop/cop/mixin/regexp_metacharacter.rb
diff --git a/....13.2/lib/rubocop/cop/mixin/sort_block.rb → ....13.3/lib/rubocop/cop/mixin/sort_block.rb b/....13.2/lib/rubocop/cop/mixin/sort_block.rb → ....13.3/lib/rubocop/cop/mixin/sort_block.rb
diff --git a/...ocop/cop/performance/ancestors_include.rb → ...ocop/cop/performance/ancestors_include.rb b/...ocop/cop/performance/ancestors_include.rb → ...ocop/cop/performance/ancestors_include.rb
diff --git a/...rmance/array_semi_infinite_range_slice.rb → ...rmance/array_semi_infinite_range_slice.rb b/...rmance/array_semi_infinite_range_slice.rb → ...rmance/array_semi_infinite_range_slice.rb
diff --git a/...ance/big_decimal_with_numeric_argument.rb → ...ance/big_decimal_with_numeric_argument.rb b/...ance/big_decimal_with_numeric_argument.rb → ...ance/big_decimal_with_numeric_argument.rb
diff --git a/.../lib/rubocop/cop/performance/bind_call.rb → .../lib/rubocop/cop/performance/bind_call.rb b/.../lib/rubocop/cop/performance/bind_call.rb → .../lib/rubocop/cop/performance/bind_call.rb
diff --git a/...rmance/block_given_with_explicit_block.rb → ...rmance/block_given_with_explicit_block.rb b/...rmance/block_given_with_explicit_block.rb → ...rmance/block_given_with_explicit_block.rb
diff --git a/...3.2/lib/rubocop/cop/performance/caller.rb → ...3.3/lib/rubocop/cop/performance/caller.rb b/...3.2/lib/rubocop/cop/performance/caller.rb → ...3.3/lib/rubocop/cop/performance/caller.rb
diff --git a/...ubocop/cop/performance/case_when_splat.rb → ...ubocop/cop/performance/case_when_splat.rb b/...ubocop/cop/performance/case_when_splat.rb → ...ubocop/cop/performance/case_when_splat.rb
diff --git a/....2/lib/rubocop/cop/performance/casecmp.rb → ....3/lib/rubocop/cop/performance/casecmp.rb b/....2/lib/rubocop/cop/performance/casecmp.rb → ....3/lib/rubocop/cop/performance/casecmp.rb
diff --git a/...cop/performance/chain_array_allocation.rb → ...cop/performance/chain_array_allocation.rb b/...cop/performance/chain_array_allocation.rb → ...cop/performance/chain_array_allocation.rb
@@ -3,18 +3,16 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop is used to identify usages of
+      # This cop is used to identify usages of `array.compact.flatten.map { |x| x.downcase }`.
+      # Each of these methods (`compact`, `flatten`, `map`) will generate a new intermediate array
+      # that is promptly thrown away. Instead it is faster to mutate when we know it's safe.
+      #
       # @example
       #   # bad
       #   array = ["a", "b", "c"]
       #   array.compact.flatten.map { |x| x.downcase }
       #
-      # Each of these methods (`compact`, `flatten`, `map`) will generate a
-      # new intermediate array that is promptly thrown away. Instead it is
-      # faster to mutate when we know it's safe.
-      #
-      # @example
-      #   # good.
+      #   # good
       #   array = ["a", "b", "c"]
       #   array.compact!
       #   array.flatten!

diff --git a/...performance/collection_literal_in_loop.rb → ...performance/collection_literal_in_loop.rb b/...performance/collection_literal_in_loop.rb → ...performance/collection_literal_in_loop.rb
diff --git a/...cop/cop/performance/compare_with_block.rb → ...cop/cop/performance/compare_with_block.rb b/...cop/cop/performance/compare_with_block.rb → ...cop/cop/performance/compare_with_block.rb
diff --git a/.../performance/concurrent_monotonic_time.rb → .../performance/concurrent_monotonic_time.rb b/.../performance/concurrent_monotonic_time.rb → .../performance/concurrent_monotonic_time.rb
diff --git a/...ubocop/cop/performance/constant_regexp.rb → ...ubocop/cop/performance/constant_regexp.rb b/...ubocop/cop/performance/constant_regexp.rb → ...ubocop/cop/performance/constant_regexp.rb
diff --git a/...13.2/lib/rubocop/cop/performance/count.rb → ...13.3/lib/rubocop/cop/performance/count.rb b/...13.2/lib/rubocop/cop/performance/count.rb → ...13.3/lib/rubocop/cop/performance/count.rb
diff --git a/.../rubocop/cop/performance/delete_prefix.rb → .../rubocop/cop/performance/delete_prefix.rb b/.../rubocop/cop/performance/delete_prefix.rb → .../rubocop/cop/performance/delete_prefix.rb
diff --git a/.../rubocop/cop/performance/delete_suffix.rb → .../rubocop/cop/performance/delete_suffix.rb b/.../rubocop/cop/performance/delete_suffix.rb → .../rubocop/cop/performance/delete_suffix.rb
diff --git a/...3.2/lib/rubocop/cop/performance/detect.rb → ...3.3/lib/rubocop/cop/performance/detect.rb b/...3.2/lib/rubocop/cop/performance/detect.rb → ...3.3/lib/rubocop/cop/performance/detect.rb
diff --git a/.../cop/performance/double_start_end_with.rb → .../cop/performance/double_start_end_with.rb b/.../cop/performance/double_start_end_with.rb → .../cop/performance/double_start_end_with.rb
diff --git a/...2/lib/rubocop/cop/performance/end_with.rb → ...3/lib/rubocop/cop/performance/end_with.rb b/...2/lib/rubocop/cop/performance/end_with.rb → ...3/lib/rubocop/cop/performance/end_with.rb
diff --git a/...lib/rubocop/cop/performance/fixed_size.rb → ...lib/rubocop/cop/performance/fixed_size.rb b/...lib/rubocop/cop/performance/fixed_size.rb → ...lib/rubocop/cop/performance/fixed_size.rb
diff --git a/...2/lib/rubocop/cop/performance/flat_map.rb → ...3/lib/rubocop/cop/performance/flat_map.rb b/...2/lib/rubocop/cop/performance/flat_map.rb → ...3/lib/rubocop/cop/performance/flat_map.rb
diff --git a/...op/performance/inefficient_hash_search.rb → ...op/performance/inefficient_hash_search.rb b/...op/performance/inefficient_hash_search.rb → ...op/performance/inefficient_hash_search.rb
diff --git a/...b/rubocop/cop/performance/io_readlines.rb → ...b/rubocop/cop/performance/io_readlines.rb b/...b/rubocop/cop/performance/io_readlines.rb → ...b/rubocop/cop/performance/io_readlines.rb
diff --git a/...ib/rubocop/cop/performance/map_compact.rb → ...ib/rubocop/cop/performance/map_compact.rb b/...ib/rubocop/cop/performance/map_compact.rb → ...ib/rubocop/cop/performance/map_compact.rb
@@ -58,17 +58,17 @@ def on_send(node)
 
           add_offense(range) do |corrector|
             corrector.replace(map_node.loc.selector, 'filter_map')
-            remove_compact_method(corrector, node, node.parent)
+            remove_compact_method(corrector, map_node, node, node.parent)
           end
         end
 
         private
 
-        def remove_compact_method(corrector, compact_node, chained_method)
+        def remove_compact_method(corrector, map_node, compact_node, chained_method)
           compact_method_range = compact_node.loc.selector
 
           if compact_node.multiline? && chained_method&.loc.respond_to?(:selector) && chained_method.dot? &&
-             !map_method_and_compact_method_on_same_line?(compact_node) &&
+             !map_method_and_compact_method_on_same_line?(map_node, compact_node) &&
              !invoke_method_after_map_compact_on_same_line?(compact_node, chained_method)
             compact_method_range = compact_method_with_final_newline_range(compact_method_range)
           else
@@ -78,11 +78,7 @@ def remove_compact_method(corrector, compact_node, chained_method)
           corrector.remove(compact_method_range)
         end
 
-        def map_method_and_compact_method_on_same_line?(compact_node)
-          return false unless compact_node.children.first.respond_to?(:send_node)
-
-          map_node = compact_node.children.first.send_node
-
+        def map_method_and_compact_method_on_same_line?(map_node, compact_node)
           compact_node.loc.selector.line == map_node.loc.selector.line
         end
 

diff --git a/...cop/performance/method_object_as_block.rb → ...cop/performance/method_object_as_block.rb b/...cop/performance/method_object_as_block.rb → ...cop/performance/method_object_as_block.rb
diff --git a/...ib/rubocop/cop/performance/open_struct.rb → ...ib/rubocop/cop/performance/open_struct.rb b/...ib/rubocop/cop/performance/open_struct.rb → ...ib/rubocop/cop/performance/open_struct.rb
diff --git a/.../rubocop/cop/performance/range_include.rb → .../rubocop/cop/performance/range_include.rb b/.../rubocop/cop/performance/range_include.rb → .../rubocop/cop/performance/range_include.rb
diff --git a/...p/cop/performance/redundant_block_call.rb → ...p/cop/performance/redundant_block_call.rb b/...p/cop/performance/redundant_block_call.rb → ...p/cop/performance/redundant_block_call.rb
diff --git a/...ce/redundant_equality_comparison_block.rb → ...ce/redundant_equality_comparison_block.rb b/...ce/redundant_equality_comparison_block.rb → ...ce/redundant_equality_comparison_block.rb
diff --git a/...ubocop/cop/performance/redundant_match.rb → ...ubocop/cop/performance/redundant_match.rb b/...ubocop/cop/performance/redundant_match.rb → ...ubocop/cop/performance/redundant_match.rb
diff --git a/...ubocop/cop/performance/redundant_merge.rb → ...ubocop/cop/performance/redundant_merge.rb b/...ubocop/cop/performance/redundant_merge.rb → ...ubocop/cop/performance/redundant_merge.rb
diff --git a/...p/cop/performance/redundant_sort_block.rb → ...p/cop/performance/redundant_sort_block.rb b/...p/cop/performance/redundant_sort_block.rb → ...p/cop/performance/redundant_sort_block.rb
diff --git a/...rmance/redundant_split_regexp_argument.rb → ...rmance/redundant_split_regexp_argument.rb b/...rmance/redundant_split_regexp_argument.rb → ...rmance/redundant_split_regexp_argument.rb
diff --git a/...cop/performance/redundant_string_chars.rb → ...cop/performance/redundant_string_chars.rb b/...cop/performance/redundant_string_chars.rb → ...cop/performance/redundant_string_chars.rb
diff --git a/...b/rubocop/cop/performance/regexp_match.rb → ...b/rubocop/cop/performance/regexp_match.rb b/...b/rubocop/cop/performance/regexp_match.rb → ...b/rubocop/cop/performance/regexp_match.rb
diff --git a/...b/rubocop/cop/performance/reverse_each.rb → ...b/rubocop/cop/performance/reverse_each.rb b/...b/rubocop/cop/performance/reverse_each.rb → ...b/rubocop/cop/performance/reverse_each.rb
diff --git a/.../rubocop/cop/performance/reverse_first.rb → .../rubocop/cop/performance/reverse_first.rb b/.../rubocop/cop/performance/reverse_first.rb → .../rubocop/cop/performance/reverse_first.rb
diff --git a/...lib/rubocop/cop/performance/select_map.rb → ...lib/rubocop/cop/performance/select_map.rb b/...lib/rubocop/cop/performance/select_map.rb → ...lib/rubocop/cop/performance/select_map.rb
diff --git a/....13.2/lib/rubocop/cop/performance/size.rb → ....13.3/lib/rubocop/cop/performance/size.rb b/....13.2/lib/rubocop/cop/performance/size.rb → ....13.3/lib/rubocop/cop/performance/size.rb
diff --git a/...b/rubocop/cop/performance/sort_reverse.rb → ...b/rubocop/cop/performance/sort_reverse.rb b/...b/rubocop/cop/performance/sort_reverse.rb → ...b/rubocop/cop/performance/sort_reverse.rb
diff --git a/....2/lib/rubocop/cop/performance/squeeze.rb → ....3/lib/rubocop/cop/performance/squeeze.rb b/....2/lib/rubocop/cop/performance/squeeze.rb → ....3/lib/rubocop/cop/performance/squeeze.rb
diff --git a/...lib/rubocop/cop/performance/start_with.rb → ...lib/rubocop/cop/performance/start_with.rb b/...lib/rubocop/cop/performance/start_with.rb → ...lib/rubocop/cop/performance/start_with.rb
diff --git a/...performance/string_identifier_argument.rb → ...performance/string_identifier_argument.rb b/...performance/string_identifier_argument.rb → ...performance/string_identifier_argument.rb
diff --git a/...rubocop/cop/performance/string_include.rb → ...rubocop/cop/performance/string_include.rb b/...rubocop/cop/performance/string_include.rb → ...rubocop/cop/performance/string_include.rb
diff --git a/...cop/cop/performance/string_replacement.rb → ...cop/cop/performance/string_replacement.rb b/...cop/cop/performance/string_replacement.rb → ...cop/cop/performance/string_replacement.rb
diff --git a/...1.13.2/lib/rubocop/cop/performance/sum.rb → ...1.13.3/lib/rubocop/cop/performance/sum.rb b/...1.13.2/lib/rubocop/cop/performance/sum.rb → ...1.13.3/lib/rubocop/cop/performance/sum.rb
diff --git a/.../lib/rubocop/cop/performance/times_map.rb → .../lib/rubocop/cop/performance/times_map.rb b/.../lib/rubocop/cop/performance/times_map.rb → .../lib/rubocop/cop/performance/times_map.rb
diff --git a/...ubocop/cop/performance/unfreeze_string.rb → ...ubocop/cop/performance/unfreeze_string.rb b/...ubocop/cop/performance/unfreeze_string.rb → ...ubocop/cop/performance/unfreeze_string.rb
diff --git a/...cop/cop/performance/uri_default_parser.rb → ...cop/cop/performance/uri_default_parser.rb b/...cop/cop/performance/uri_default_parser.rb → ...cop/cop/performance/uri_default_parser.rb
diff --git a/....13.2/lib/rubocop/cop/performance_cops.rb → ....13.3/lib/rubocop/cop/performance_cops.rb b/....13.2/lib/rubocop/cop/performance_cops.rb → ....13.3/lib/rubocop/cop/performance_cops.rb
diff --git a/...ormance-1.13.2/lib/rubocop/performance.rb → ...ormance-1.13.3/lib/rubocop/performance.rb b/...ormance-1.13.2/lib/rubocop/performance.rb → ...ormance-1.13.3/lib/rubocop/performance.rb
diff --git a/...-1.13.2/lib/rubocop/performance/inject.rb → ...-1.13.3/lib/rubocop/performance/inject.rb b/...-1.13.2/lib/rubocop/performance/inject.rb → ...-1.13.3/lib/rubocop/performance/inject.rb
diff --git a/...1.13.2/lib/rubocop/performance/version.rb → ...1.13.3/lib/rubocop/performance/version.rb b/...1.13.2/lib/rubocop/performance/version.rb → ...1.13.3/lib/rubocop/performance/version.rb
@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.13.2'
+      STRING = '1.13.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s