rubocops/cask: fix style

Homebrew · Feb 5, 2024 · 60914a3 · 60914a3
1 parent 2b60576
commit 60914a3
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb b/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb
@@ -8,22 +8,23 @@ class SharedFilelistGlob < Base
         extend AutoCorrector
 
         def on_send(node)
-          return unless node.method_name == :zap
+          return if node.method_name != :zap
 
           node.each_descendant(:pair).each do |pair|
             symbols = pair.children.select(&:sym_type?).map(&:value)
             next unless symbols.include?(:trash)
 
             pair.each_descendant(:array).each do |array|
-
               regex = /sfl\d"$/
+              message = "Use a glob (*) instead of a specific version (ie. sfl2) for trashing Shared File List paths"
 
               array.children.each do |item|
-               next unless item.source.match?(regex)
+                next unless item.source.match?(regex)
 
-               corrected_item = item.source.sub(/sfl\d"$/, "sfl*\"")
+                corrected_item = item.source.sub(/sfl\d"$/, "sfl*\"")
 
-               add_offense(item, message: "Use a glob (*) instead of a specific version (ie. sfl2) for trashing Shared File List paths") do |corrector|
+                add_offense(item,
+                            message: message) do |corrector|
                   corrector.replace(item, corrected_item)
                 end
               end