rubocops/uses_from_macos: audit when depends_on :linux

Homebrew · Dec 21, 2023 · 728f57a · 728f57a
1 parent 4a8d9ce
commit 728f57a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/Library/Homebrew/rubocops/uses_from_macos.rb b/Library/Homebrew/rubocops/uses_from_macos.rb
@@ -98,7 +98,12 @@ class UsesFromMacos < FormulaCop
         def audit_formula(_node, _class_node, _parent_class_node, body_node)
           return if body_node.nil?
 
-          find_method_with_args(body_node, :uses_from_macos, /^"(.+)"/).each do |method|
+          uses_from_macos_nodes = find_method_with_args(body_node, :uses_from_macos, /^"(.+)"/)
+          return if uses_from_macos_nodes.blank?
+
+          problem "`uses_from_macos` should not be used when Linux is required." if depends_on?(:linux)
+
+          uses_from_macos_nodes.each do |method|
             dep = if parameters(method).first.instance_of?(RuboCop::AST::StrNode)
               parameters(method).first
             elsif parameters(method).first.instance_of?(RuboCop::AST::HashNode)