Skip to content

Commit

Permalink
Merge pull request #13833 from carlocab/libcxx-linkage
Browse files Browse the repository at this point in the history
linkage_checker: ignore broken linkage with LLVM libc++.
  • Loading branch information
carlocab committed Sep 19, 2022
2 parents 65eff65 + 957c2c9 commit 7603418
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Library/Homebrew/linkage_checker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,12 @@ def sort_by_formula_full_name!(arr)
def harmless_broken_link?(dylib)
# libgcc_s_* is referenced by programs that use the Java Service Wrapper,
# and is harmless on x86(_64) machines
# dyld will fall back to Apple libc++ if LLVM's is not available.
[
"/usr/lib/libgcc_s_ppc64.1.dylib",
"/opt/local/lib/libgcc/libgcc_s.1.dylib",
# TODO: Report linkage with `/usr/lib/libc++.1.dylib` when this link is broken.
"#{HOMEBREW_PREFIX}/opt/llvm/lib/libc++.1.dylib",
].include?(dylib)
end

Expand Down

0 comments on commit 7603418

Please sign in to comment.