Skip to content

Commit

Permalink
Version: Improve date version parsing
Browse files Browse the repository at this point in the history
The existing date version parsing regex only matches file names that
have a prefix (e.g., `ltopers-v2017-04-14.tar.gz`), so it doesn't
match files like `2023-09-28.tar.gz`. There are a handful of formulae
that have to manually specify the version as a result (e.g.,
`marksman`, `sqtop`, etc.). `bootloadhid` is also affected but that's
because the filename uses a dot as the prefix delimiter (e.g.,
`bootloadHID.2012-12-08.tar.gz`) and the regex only matches a hyphen.

This addresses these shortcomings by using `[._-]` as the prefix
delimiter and making it optional.
  • Loading branch information
samford committed Oct 4, 2023
1 parent 75b18b5 commit 7626bdd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Library/Homebrew/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,9 @@ def self.parse(spec, detected_from_url: false)

VERSION_PARSERS = [
# date-based versioning
# e.g. 2023-09-28.tar.gz
# e.g. ltopers-v2017-04-14.tar.gz
StemParser.new(/-v?(\d{4}-\d{2}-\d{2})/),
StemParser.new(/[._-]?v?(\d{4}-\d{2}-\d{2})/),

# GitHub tarballs
# e.g. https://github.com/foo/bar/tarball/v1.2.3
Expand Down

0 comments on commit 7626bdd

Please sign in to comment.