Skip to content

Commit

Permalink
Merge pull request #7377 from Homebrew/dependabot/bundler/Library/Hom…
Browse files Browse the repository at this point in the history
…ebrew/rubocop-0.82.0

build(deps): bump rubocop from 0.81.0 to 0.82.0 in /Library/Homebrew
  • Loading branch information
MikeMcQuaid committed Apr 17, 2020
2 parents 04105ab + bc96428 commit 88fb5ca
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 7 deletions.
19 changes: 13 additions & 6 deletions Library/.rubocop.yml
Expand Up @@ -8,6 +8,19 @@ FormulaAudit:
FormulaAuditStrict:
Enabled: true

# enable all pending rubocops
AllCops:
NewCops: enable

# don't allow cops to be disabled in formulae
Style/DisableCopsWithinSourceCodeDirective:
Enabled: true
Exclude:
# TODO: really long lines but hard to resolve (but would be nice to do).
- '**/Formula/libgraphqlparser.rb'
# TODO: false positive in RuboCop, see if it can be worked around/fixed.
- '**/Formula/rpm.rb'

# make our hashes consistent
Layout/HashAlignment:
EnforcedHashRocketStyle: table
Expand Down Expand Up @@ -46,12 +59,6 @@ Lint/AmbiguousRegexpLiteral:
Lint/ParenthesesAsGroupedExpression:
Enabled: false

# not enabled by default but nice to have
Lint/RaiseException:
Enabled: true
Lint/StructNewOverride:
Enabled: true

# most metrics don't make sense to apply for formulae/taps
Metrics/AbcSize:
Enabled: false
Expand Down
4 changes: 4 additions & 0 deletions Library/.rubocop_rspec.yml
Expand Up @@ -8,6 +8,10 @@ AllCops:
Exclude:
- '**/vendor/**/*'

# allow style to be disabled in non-formulae code
Style/DisableCopsWithinSourceCodeDirective:
Enabled: false

# Intentionally disabled as it doesn't fit with our code style.
RSpec/AnyInstance:
Enabled: false
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/Gemfile.lock
Expand Up @@ -81,7 +81,7 @@ GEM
rspec-support (3.9.2)
rspec-wait (0.0.9)
rspec (>= 3, < 4)
rubocop (0.81.0)
rubocop (0.82.0)
jaro_winkler (~> 1.5.1)
parallel (~> 1.10)
parser (>= 2.7.0.1)
Expand Down

0 comments on commit 88fb5ca

Please sign in to comment.