Merge pull request #3740 from reitermarkus/cask-style

Fix `brew cask style` on Travis.
Homebrew · Jan 28, 2018 · 9f4b4a1 · 9f4b4a1
2 parents 5244755 + 884c57f
commit 9f4b4a1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/Library/Homebrew/cask/lib/hbc/cli/style.rb b/Library/Homebrew/cask/lib/hbc/cli/style.rb
@@ -10,9 +10,9 @@ def self.help
       def run
         install_rubocop
         cache_env = { "XDG_CACHE_HOME" => "#{HOMEBREW_CACHE}/style" }
-        system(cache_env, "rubocop", *rubocop_args, "--", *cask_paths)
+        hide_warnings = debug? ? [] : [ENV["HOMEBREW_RUBY_PATH"], "-W0", "-S"]
+        system(cache_env, *hide_warnings, "rubocop", *rubocop_args, "--", *cask_paths)
         raise CaskError, "style check failed" unless $CHILD_STATUS.success?
-        true
       end
 
       def install_rubocop
@@ -43,8 +43,8 @@ def default_args
         [
           "--require", "rubocop-cask",
           "--force-default-config",
-          "--force-exclusion",
-          "--format", "simple"
+          "--format", "simple",
+          "--parallel"
         ]
       end
 

diff --git a/Library/Homebrew/test/cask/cli/style_spec.rb b/Library/Homebrew/test/cask/cli/style_spec.rb
@@ -22,7 +22,10 @@
 
     context "when rubocop succeeds" do
       let(:success) { true }
-      it { is_expected.to be_truthy }
+
+      it "does not raise an error" do
+        expect { subject }.not_to raise_error
+      end
     end
 
     context "when rubocop fails" do
@@ -132,7 +135,7 @@
   describe "#default_args" do
     subject { cli.default_args }
 
-    it { is_expected.to include("--require", "rubocop-cask", "--format", "simple", "--force-exclusion") }
+    it { is_expected.to include("--require", "rubocop-cask", "--format", "simple") }
   end
 
   describe "#autocorrect_args" do