Skip to content

Commit

Permalink
formula_auditor: make Linux-only GCC dep audit non-strict.
Browse files Browse the repository at this point in the history
Otherwise we have to run this separately in `brew test-bot` which is
slower and more confusing.
  • Loading branch information
MikeMcQuaid committed Sep 3, 2023
1 parent 9b76182 commit b594e87
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions Library/Homebrew/formula_auditor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -445,16 +445,9 @@ def audit_conflicts

def audit_gcc_dependency
return unless @core_tap
return if !@strict && !(@git && formula.tap.git?) # git log is required for non-strict audit
return unless Homebrew::SimulateSystem.simulating_or_running_on_linux?
return unless linux_only_gcc_dep?(formula)

bad_gcc_dep = @strict || begin
fv = FormulaVersions.new(formula)
fv.formula_at_revision("origin/HEAD") { |prev_f| !linux_only_gcc_dep?(prev_f) }
end
return unless bad_gcc_dep

problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC."
end

Expand Down

0 comments on commit b594e87

Please sign in to comment.