Merge pull request #8404 from reitermarkus/missing-methods

Fix missing methods in cask DSL.

Library/Homebrew/cask/dsl.rb

@@ -282,6 +282,10 @@ def auto_updates(auto_updates = nil)
       end
     end
 
+    def respond_to_missing?(*)
+      super
+    end
+
     def method_missing(method, *)
       if method
         Utils.method_missing_message(method, token)
@@ -291,10 +295,6 @@ def method_missing(method, *)
       end
     end
 
-    def respond_to_missing?(*)
-      super || true
-    end
-
     def appdir
       cask.config.appdir
     end

Library/Homebrew/cask/dsl/base.rb

@@ -18,6 +18,10 @@ def system_command(executable, **options)
         @command.run!(executable, **options)
       end
 
+      def respond_to_missing?(*)
+        super
+      end
+
       def method_missing(method, *)
         if method
           underscored_class = self.class.name.gsub(/([[:lower:]])([[:upper:]][[:lower:]])/, '\1_\2').downcase
@@ -28,10 +32,6 @@ def method_missing(method, *)
           super
         end
       end
-
-      def respond_to_missing?(*)
-        super || true
-      end
     end
   end
 end

Library/Homebrew/cask/utils.rb

@@ -80,12 +80,11 @@ def self.error_message_with_suggestions
     end
 
     def self.method_missing_message(method, token, section = nil)
-      poo = []
-      poo << "Unexpected method '#{method}' called"
-      poo << "during #{section}" if section
-      poo << "on Cask #{token}."
+      message = +"Unexpected method '#{method}' called "
+      message << "during #{section} " if section
+      message << "on Cask #{token}."
 
-      opoo("#{poo.join(" ")}\n#{error_message_with_suggestions}")
+      opoo "#{message}\n#{error_message_with_suggestions}"
     end
   end
 end