svn: work around certificate errors on macOS pre-10.15

Homebrew · Oct 22, 2021 · b99a4bd · b99a4bd
1 parent e518ea4
commit b99a4bd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb
@@ -763,7 +763,9 @@ def fetch_repo(target, url, revision = nil, ignore_externals: false, timeout: ni
 
     args << "--ignore-externals" if ignore_externals
 
-    if meta[:trust_cert] == true
+    svn_version = Version.create(Utils::Svn.version)
+    if meta[:trust_cert] == true || svn_version <= Version.create("1.10")
+      args << "--trust-server-cert-failures=expired,not-yet-valid" if svn_version >= Version.create("1.9")
       args << "--trust-server-cert"
       args << "--non-interactive"
     end

diff --git a/Library/Homebrew/utils/svn.rb b/Library/Homebrew/utils/svn.rb
@@ -32,7 +32,8 @@ def remote_exists?(url)
 
         # OK to unconditionally trust here because we're just checking if a URL exists.
         system_command("svn", args: ["ls", url, "--depth", "empty",
-                                     "--non-interactive", "--trust-server-cert"], print_stderr: false).success?
+                                     "--trust-server-cert-failures=expired,not-yet-valid",
+                                     "--trust-server-cert", "--non-interactive"], print_stderr: false).success?
       end
 
       def clear_version_cache