Skip to content

Commit

Permalink
dev-cmd/edit: simplify project view handling.
Browse files Browse the repository at this point in the history
The way Homebrew is structured now there鈥檚 no need to manually
specify a few different directories here.
  • Loading branch information
MikeMcQuaid committed Sep 6, 2018
1 parent 88bf60d commit c6b6fc6
Showing 1 changed file with 7 additions and 28 deletions.
35 changes: 7 additions & 28 deletions Library/Homebrew/dev-cmd/edit.rb
Expand Up @@ -26,36 +26,15 @@ def edit
end

# If no brews are listed, open the project root in an editor.
if ARGV.named.empty?
editor = File.basename which_editor
if ["atom", "subl", "mate"].include?(editor)
# If the user is using Atom, Sublime Text or TextMate
# give a nice project view instead.
exec_editor HOMEBREW_REPOSITORY/"bin/brew",
HOMEBREW_REPOSITORY/"README.md",
HOMEBREW_REPOSITORY/".gitignore",
*library_folders
else
exec_editor HOMEBREW_REPOSITORY
end
else
# Don't use ARGV.formulae as that will throw if the file doesn't parse
paths = ARGV.named.map do |name|
path = Formulary.path(name)
paths = [HOMEBREW_REPOSITORY] if ARGV.named.empty?

raise FormulaUnavailableError, name unless path.file? || args.force?

path
end
exec_editor(*paths)
# Don't use ARGV.formulae as that will throw if the file doesn't parse
paths ||= ARGV.named.map do |name|
path = Formulary.path(name)
raise FormulaUnavailableError, name if !path.file? && !args.force?
path
end
end

def library_folders
Dir["#{HOMEBREW_LIBRARY}/*"].reject do |d|
case File.basename(d)
when "LinkedKegs", "Aliases" then true
end
end
exec_editor(*paths)
end
end

0 comments on commit c6b6fc6

Please sign in to comment.