Skip to content

Commit

Permalink
Merge pull request #3248 from reitermarkus/audit-warning
Browse files Browse the repository at this point in the history
Add audit warning if previous Cask version cannot be read.
  • Loading branch information
reitermarkus committed Oct 1, 2017
2 parents 55dd44e + d9a474e commit e86c79f
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions Library/Homebrew/cask/lib/hbc/audit.rb
Expand Up @@ -70,12 +70,16 @@ def check_version_and_checksum
previous_cask_contents = Git.last_revision_of_file(tap.path, @cask.sourcefile_path, before_commit: commit_range)
return if previous_cask_contents.empty?

previous_cask = CaskLoader.load_from_string(previous_cask_contents)
begin
previous_cask = CaskLoader.load_from_string(previous_cask_contents)

return unless previous_cask.version == cask.version
return if previous_cask.sha256 == cask.sha256
return unless previous_cask.version == cask.version
return if previous_cask.sha256 == cask.sha256

add_error "only sha256 changed (see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)"
add_error "only sha256 changed (see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)"
rescue CaskError => e
add_warning "Skipped version and checksum comparison. Reading previous version failed: #{e}"
end
end

def check_version
Expand Down

0 comments on commit e86c79f

Please sign in to comment.