Merge pull request #13216 from Homebrew/dependabot/bundler/Library/Ho…

…mebrew/rubocop-sorbet-0.6.8 build(deps): bump rubocop-sorbet from 0.6.7 to 0.6.8 in /Library/Homebrew
Homebrew · Apr 29, 2022 · ea72240 · ea72240
2 parents 2c0bd31 + 00909fc
commit ea72240
Show file tree

Hide file tree

Showing 39 changed files with 57 additions and 6 deletions.
diff --git a/Library/Homebrew/Gemfile.lock b/Library/Homebrew/Gemfile.lock
@@ -143,7 +143,7 @@ GEM
       rubocop (>= 1.7.0, < 2.0)
     rubocop-rspec (2.10.0)
       rubocop (~> 1.19)
-    rubocop-sorbet (0.6.7)
+    rubocop-sorbet (0.6.8)
       rubocop (>= 0.90.0)
     ruby-macho (3.0.0)
     ruby-progressbar (1.11.0)

diff --git a/.../sorbet/rbi/gems/rubocop-sorbet@0.6.7.rbi → .../sorbet/rbi/gems/rubocop-sorbet@0.6.8.rbi b/.../sorbet/rbi/gems/rubocop-sorbet@0.6.7.rbi → .../sorbet/rbi/gems/rubocop-sorbet@0.6.8.rbi
diff --git a/Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi b/Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -5239,6 +5239,11 @@ class RuboCop::Cop::FormulaCop
   def required_dependency_name?(param0, param1); end
 end
 
+class RuboCop::Cop::Style::MutableConstant
+  include ::RuboCop::Cop::Sorbet::MutableConstantSorbetAwareBehaviour
+  def t_let(param0=T.unsafe(nil)); end
+end
+
 module RuboCop::RSpec::ExpectOffense
   def expect_correction(correction, loop: T.unsafe(nil), source: T.unsafe(nil)); end
 

diff --git a/Library/Homebrew/vendor/bundle/bundler/setup.rb b/Library/Homebrew/vendor/bundle/bundler/setup.rb
@@ -88,7 +88,7 @@
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-performance-1.13.3/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rails-2.14.2/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-rspec-2.10.0/lib"
-$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-sorbet-0.6.7/lib"
+$:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/rubocop-sorbet-0.6.8/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/ruby-macho-3.0.0/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/simplecov-html-0.12.3/lib"
 $:.unshift "#{path}/../#{ruby_engine}/#{ruby_version}/gems/simplecov_json_formatter-0.1.4/lib"

diff --git a/...s/rubocop-sorbet-0.6.7/config/default.yml → ...s/rubocop-sorbet-0.6.8/config/default.yml b/...s/rubocop-sorbet-0.6.7/config/default.yml → ...s/rubocop-sorbet-0.6.8/config/default.yml
diff --git a/.../gems/rubocop-sorbet-0.6.7/config/rbi.yml → .../gems/rubocop-sorbet-0.6.8/config/rbi.yml b/.../gems/rubocop-sorbet-0.6.7/config/rbi.yml → .../gems/rubocop-sorbet-0.6.8/config/rbi.yml
diff --git a/...ubocop-sorbet-0.6.7/lib/rubocop-sorbet.rb → ...ubocop-sorbet-0.6.8/lib/rubocop-sorbet.rb b/...ubocop-sorbet-0.6.7/lib/rubocop-sorbet.rb → ...ubocop-sorbet-0.6.8/lib/rubocop-sorbet.rb
diff --git a/...t/binding_constants_without_type_alias.rb → ...t/binding_constants_without_type_alias.rb b/...t/binding_constants_without_type_alias.rb → ...t/binding_constants_without_type_alias.rb
@@ -57,12 +57,18 @@ class BindingConstantWithoutTypeAlias < RuboCop::Cop::Cop
           )
         PATTERN
 
-        def_node_matcher(:generic_parameter_decl?, <<-PATTERN)
+        def_node_matcher(:generic_parameter_decl_call?, <<-PATTERN)
           (
             send nil? {:type_template :type_member} ...
           )
         PATTERN
 
+        def_node_matcher(:generic_parameter_decl_block_call?, <<-PATTERN)
+          (block
+            (send nil? {:type_template :type_member}) ...
+          )
+        PATTERN
+
         def_node_search(:method_needing_aliasing_on_t?, <<-PATTERN)
           (
             send
@@ -81,7 +87,7 @@ def not_dynamic_type_creation_with_block?(node)
         end
 
         def not_generic_parameter_decl?(node)
-          !generic_parameter_decl?(node)
+          !generic_parameter_decl_call?(node) && !generic_parameter_decl_block_call?(node)
         end
 
         def not_nil?(node)

diff --git a/...p/sorbet/callback_conditionals_binding.rb → ...p/sorbet/callback_conditionals_binding.rb b/...p/sorbet/callback_conditionals_binding.rb → ...p/sorbet/callback_conditionals_binding.rb
diff --git a/...ocop/cop/sorbet/constants_from_strings.rb → ...ocop/cop/sorbet/constants_from_strings.rb b/...ocop/cop/sorbet/constants_from_strings.rb → ...ocop/cop/sorbet/constants_from_strings.rb
diff --git a/...op/sorbet/forbid_include_const_literal.rb → ...op/sorbet/forbid_include_const_literal.rb b/...op/sorbet/forbid_include_const_literal.rb → ...op/sorbet/forbid_include_const_literal.rb
diff --git a/...sorbet/forbid_superclass_const_literal.rb → ...sorbet/forbid_superclass_const_literal.rb b/...sorbet/forbid_superclass_const_literal.rb → ...sorbet/forbid_superclass_const_literal.rb
diff --git a/...lib/rubocop/cop/sorbet/forbid_t_unsafe.rb → ...lib/rubocop/cop/sorbet/forbid_t_unsafe.rb b/...lib/rubocop/cop/sorbet/forbid_t_unsafe.rb → ...lib/rubocop/cop/sorbet/forbid_t_unsafe.rb
diff --git a/...cop/sorbet/forbid_untyped_struct_props.rb → ...cop/sorbet/forbid_untyped_struct_props.rb b/...cop/sorbet/forbid_untyped_struct_props.rb → ...cop/sorbet/forbid_untyped_struct_props.rb
diff --git a/...ms/rubocop-sorbet-0.6.8/lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb b/...ms/rubocop-sorbet-0.6.8/lib/rubocop/cop/sorbet/mutable_constant_sorbet_aware_behaviour.rb
@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require "rubocop/cop/style/mutable_constant"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      module MutableConstantSorbetAwareBehaviour
+        def self.prepended(base)
+          base.def_node_matcher(:t_let, <<~PATTERN)
+            (send (const nil? :T) :let $_constant _type)
+          PATTERN
+        end
+
+        def on_assignment(value)
+          t_let(value) do |constant|
+            value = constant
+          end
+
+          super(value)
+        end
+      end
+    end
+  end
+end
+
+RuboCop::Cop::Style::MutableConstant.prepend(
+  RuboCop::Cop::Sorbet::MutableConstantSorbetAwareBehaviour
+)
diff --git a/...bocop/cop/sorbet/one_ancestor_per_line.rb → ...bocop/cop/sorbet/one_ancestor_per_line.rb b/...bocop/cop/sorbet/one_ancestor_per_line.rb → ...bocop/cop/sorbet/one_ancestor_per_line.rb
diff --git a/...i/forbid_extend_t_sig_helpers_in_shims.rb → ...i/forbid_extend_t_sig_helpers_in_shims.rb b/...i/forbid_extend_t_sig_helpers_in_shims.rb → ...i/forbid_extend_t_sig_helpers_in_shims.rb
diff --git a/...bi/forbid_rbi_outside_of_allowed_paths.rb → ...bi/forbid_rbi_outside_of_allowed_paths.rb b/...bi/forbid_rbi_outside_of_allowed_paths.rb → ...bi/forbid_rbi_outside_of_allowed_paths.rb
diff --git a/...ngle_line_rbi_class_module_definitions.rb → ...ngle_line_rbi_class_module_definitions.rb b/...ngle_line_rbi_class_module_definitions.rb → ...ngle_line_rbi_class_module_definitions.rb
diff --git a/.../cop/sorbet/sigils/enforce_sigil_order.rb → .../cop/sorbet/sigils/enforce_sigil_order.rb b/.../cop/sorbet/sigils/enforce_sigil_order.rb → .../cop/sorbet/sigils/enforce_sigil_order.rb
diff --git a/...cop/sorbet/sigils/enforce_single_sigil.rb → ...cop/sorbet/sigils/enforce_single_sigil.rb b/...cop/sorbet/sigils/enforce_single_sigil.rb → ...cop/sorbet/sigils/enforce_single_sigil.rb
diff --git a/.../rubocop/cop/sorbet/sigils/false_sigil.rb → .../rubocop/cop/sorbet/sigils/false_sigil.rb b/.../rubocop/cop/sorbet/sigils/false_sigil.rb → .../rubocop/cop/sorbet/sigils/false_sigil.rb
diff --git a/...ib/rubocop/cop/sorbet/sigils/has_sigil.rb → ...ib/rubocop/cop/sorbet/sigils/has_sigil.rb b/...ib/rubocop/cop/sorbet/sigils/has_sigil.rb → ...ib/rubocop/cop/sorbet/sigils/has_sigil.rb
diff --git a/...rubocop/cop/sorbet/sigils/ignore_sigil.rb → ...rubocop/cop/sorbet/sigils/ignore_sigil.rb b/...rubocop/cop/sorbet/sigils/ignore_sigil.rb → ...rubocop/cop/sorbet/sigils/ignore_sigil.rb
diff --git a/...rubocop/cop/sorbet/sigils/strict_sigil.rb → ...rubocop/cop/sorbet/sigils/strict_sigil.rb b/...rubocop/cop/sorbet/sigils/strict_sigil.rb → ...rubocop/cop/sorbet/sigils/strict_sigil.rb
diff --git a/...rubocop/cop/sorbet/sigils/strong_sigil.rb → ...rubocop/cop/sorbet/sigils/strong_sigil.rb b/...rubocop/cop/sorbet/sigils/strong_sigil.rb → ...rubocop/cop/sorbet/sigils/strong_sigil.rb
diff --git a/...b/rubocop/cop/sorbet/sigils/true_sigil.rb → ...b/rubocop/cop/sorbet/sigils/true_sigil.rb b/...b/rubocop/cop/sorbet/sigils/true_sigil.rb → ...b/rubocop/cop/sorbet/sigils/true_sigil.rb
diff --git a/.../rubocop/cop/sorbet/sigils/valid_sigil.rb → .../rubocop/cop/sorbet/sigils/valid_sigil.rb b/.../rubocop/cop/sorbet/sigils/valid_sigil.rb → .../rubocop/cop/sorbet/sigils/valid_sigil.rb
diff --git a/...signatures/allow_incompatible_override.rb → ...signatures/allow_incompatible_override.rb b/...signatures/allow_incompatible_override.rb → ...signatures/allow_incompatible_override.rb
diff --git a/...t/signatures/checked_true_in_signature.rb → ...t/signatures/checked_true_in_signature.rb b/...t/signatures/checked_true_in_signature.rb → ...t/signatures/checked_true_in_signature.rb
diff --git a/...p/sorbet/signatures/enforce_signatures.rb → ...p/sorbet/signatures/enforce_signatures.rb b/...p/sorbet/signatures/enforce_signatures.rb → ...p/sorbet/signatures/enforce_signatures.rb
diff --git a/...t/signatures/keyword_argument_ordering.rb → ...t/signatures/keyword_argument_ordering.rb b/...t/signatures/keyword_argument_ordering.rb → ...t/signatures/keyword_argument_ordering.rb
diff --git a/...orbet/signatures/signature_build_order.rb → ...orbet/signatures/signature_build_order.rb b/...orbet/signatures/signature_build_order.rb → ...orbet/signatures/signature_build_order.rb
diff --git a/...op/cop/sorbet/signatures/signature_cop.rb → ...op/cop/sorbet/signatures/signature_cop.rb b/...op/cop/sorbet/signatures/signature_cop.rb → ...op/cop/sorbet/signatures/signature_cop.rb
diff --git a/...lib/rubocop/cop/sorbet/type_alias_name.rb → ...lib/rubocop/cop/sorbet/type_alias_name.rb b/...lib/rubocop/cop/sorbet/type_alias_name.rb → ...lib/rubocop/cop/sorbet/type_alias_name.rb
diff --git a/...rbet-0.6.7/lib/rubocop/cop/sorbet_cops.rb → ...rbet-0.6.8/lib/rubocop/cop/sorbet_cops.rb b/...rbet-0.6.7/lib/rubocop/cop/sorbet_cops.rb → ...rbet-0.6.8/lib/rubocop/cop/sorbet_cops.rb
@@ -28,3 +28,5 @@
 require_relative "sorbet/sigils/strong_sigil"
 require_relative "sorbet/sigils/enforce_sigil_order"
 require_relative "sorbet/sigils/enforce_single_sigil"
+
+require_relative "sorbet/mutable_constant_sorbet_aware_behaviour"
diff --git a/...ubocop-sorbet-0.6.7/lib/rubocop/sorbet.rb → ...ubocop-sorbet-0.6.8/lib/rubocop/sorbet.rb b/...ubocop-sorbet-0.6.7/lib/rubocop/sorbet.rb → ...ubocop-sorbet-0.6.8/lib/rubocop/sorbet.rb
diff --git a/...sorbet-0.6.7/lib/rubocop/sorbet/inject.rb → ...sorbet-0.6.8/lib/rubocop/sorbet/inject.rb b/...sorbet-0.6.7/lib/rubocop/sorbet/inject.rb → ...sorbet-0.6.8/lib/rubocop/sorbet/inject.rb
diff --git a/...orbet-0.6.7/lib/rubocop/sorbet/version.rb → ...orbet-0.6.8/lib/rubocop/sorbet/version.rb b/...orbet-0.6.7/lib/rubocop/sorbet/version.rb → ...orbet-0.6.8/lib/rubocop/sorbet/version.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RuboCop
   module Sorbet
-    VERSION = "0.6.7"
+    VERSION = "0.6.8"
   end
 end