Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved bottle reproducibility #11149

Closed
2 tasks done
MikeMcQuaid opened this issue Apr 15, 2021 · 3 comments
Closed
2 tasks done

Improved bottle reproducibility #11149

MikeMcQuaid opened this issue Apr 15, 2021 · 3 comments
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 15, 2021

Provide a detailed description of the proposed feature

With brew bottle --json --only-json-tab we now have the ability to create reproducible bottles. This has been demonstrated by Homebrew/homebrew-core@c6180a0

Will add to this issue as issues are discovered:

  • created files are owned as brew:admin on our ARM64 Big Sur CI boxes and brew:staff elsewhere
    • should be relatively easy, one-time job to update this on our workers so they are consistent (in either direction)
  • /usr/local/share/ is not replaced with @@HOMEBREW_PREFIX@@/share/ on ARM64 Big Sur CI boxes (and likely wouldn't be on Linux) but is on x86_64 macOS CI boxes. This happens even when it's not actually a reference to the Homebrew prefix but just the default system paths. This likely affects a non-trivial number of bottles.
    • not sure how best to handle this (or even if we can)

What is the motivation for the feature?

  • Reducing the storage impact of bottles in GitHub Packages and in the local cache (when upgrading macOS versions).
  • The motivation for https://reproducible-builds.org

How will the feature be relevant to at least 90% of Homebrew users?

It probably won't be!

What alternatives to the feature have been considered?

The status quo.

@MikeMcQuaid MikeMcQuaid added help wanted We want help addressing this features New features labels Apr 15, 2021
MikeMcQuaid referenced this issue in Homebrew/homebrew-core Apr 15, 2021
@MikeMcQuaid
Copy link
Member Author

(If you want to find more issues like this: use diffoscope with the two downloaded bottle tarball files as input)

@MikeMcQuaid
Copy link
Member Author

[ ] created files are owned as brew:admin on our ARM64 Big Sur CI boxes and brew:staff elsewhere

  • should be relatively easy, one-time job to update this on our workers so they are consistent (in either direction)

Should be fixed in #11150 (without needing to update the workers).

@MikeMcQuaid
Copy link
Member Author

Closing this as consider it generally done.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

1 participant