-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autosquash can't squash commits that modify non-formula files #12939
Comments
Specifically, the bug is that this line fails to take into account that formula files can lie outside of a brew/Library/Homebrew/dev-cmd/pr-pull.rb Line 227 in b4244bb
|
Given these commands exist primarily for our workflow: I'm tempted to say "we'll review a PR to fix this but don't plan on doing so ourselves" (unless you'd like to, @Bo98). |
The workaround also seems to be pretty straightforward: just move your formulae into a |
brew config
outputbrew doctor
outputVerification
brew update
and am still able to reproduce my issue.brew doctor
and that did not fix my problem.What were you trying to do (and why)?
Merge a PR in a tap by labeling it with "pr-pull". The PR in question only modifies the version of a formula: https://github.com/coin-or-tools/homebrew-coinor/pull/81/files
What happened (include all command output)?
The job fails with the error message
https://github.com/coin-or-tools/homebrew-coinor/runs/5365992002?check_suite_focus=true#step:4:20
What did you expect to happen?
Expected the bottles to be published and the PR to be merged.
Step-by-step reproduction instructions (by running
brew
commands)The issue occurs in GitHub Actions on a tap, not by manually running brew commands. The issue was reported here: https://github.com/Homebrew/discussions/discussions/3033 and I was advised to open an issue on this repository.
The text was updated successfully, but these errors were encountered: