Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: disallow protocol in cask url verified stanza #14717

Closed
1 task done
SMillerDev opened this issue Feb 20, 2023 · 1 comment · Fixed by #14886
Closed
1 task done

rubocop: disallow protocol in cask url verified stanza #14717

SMillerDev opened this issue Feb 20, 2023 · 1 comment · Fixed by #14886
Assignees
@issyl0
Labels
features New features good first issue A good issue for your first contribution to Homebrew/brew in progress Maintainers are working on this outdated PR was locked due to age

Comments

@SMillerDev
Copy link
Member

Verification

Provide a detailed description of the proposed feature

A rubocop that will check to ensure that no protocol is included in the verified: part of the url stanza.

What is the motivation for the feature?

Avoid PRs like Homebrew/homebrew-cask#141567 (review) before they're needed.

How will the feature be relevant to at least 90% of Homebrew users?

Less manual maintainer work. Happier maintainers. Happier users

What alternatives to the feature have been considered?

Keeping the current manual checks
@SMillerDev SMillerDev added features New features help wanted We want help addressing this good first issue A good issue for your first contribution to Homebrew/brew labels Feb 20, 2023
@miccal
Copy link
Member

miccal commented Feb 20, 2023 •
edited

Thanks @SMillerDev. There are currently only 33 Casks that have the protocol in the verified: parameter:

1password-cli-beta
ares
boom-3d
coscreen
deskreen
encryptr
equinox
folx
genki-softwave
genki-wave-for-work
goxel
internxt-drive
izotope-product-portal
masscode
mds
neat
obsbot-webcam
orka-vm-tools
osculator
podman-desktop
pokemon-trading-card-game-online
ptpwebcam
reolink-client
restream-chat
scatter
shield
snes9x
sony-xperia-companion
soundtoys
vial
wine-devel
wine-staging
wxmacmolplt

@issyl0 issyl0 self-assigned this Mar 4, 2023
@issyl0 issyl0 added in progress Maintainers are working on this and removed help wanted We want help addressing this labels Mar 4, 2023
@issyl0 issyl0 mentioned this issue Mar 4, 2023
Merged
7 tasks
issyl0 added a commit to issyl0/homebrew-cask that referenced this issue Mar 5, 2023
@issyl0
youdaonote: Remove protocol from verified stanza
2a0acc3 
- According to Homebrew/brew#14717 it's wrong
  to have the protocol in the "verified" part of a Cask URL. So there's
  now an autocorrecting RuboCop for it at
  Homebrew/brew#14886. This fixes the singular
  offense.
@issyl0 issyl0 mentioned this issue Mar 5, 2023
Closed
9 tasks
p-linnane pushed a commit to p-linnane/homebrew-cask that referenced this issue Mar 5, 2023
@issyl0 @p-linnane
youdaonote: Remove protocol from verified stanza
a35687c 
- According to Homebrew/brew#14717 it's wrong
  to have the protocol in the "verified" part of a Cask URL. So there's
  now an autocorrecting RuboCop for it at
  Homebrew/brew#14886. This fixes the singular
  offense.
p-linnane added a commit to Homebrew/homebrew-cask that referenced this issue Mar 5, 2023
@p-linnane @issyl0
Update youdaonote from 7.2.3 to 7.2.4 (#142325)
a0772cf 
* Update youdaonote from 7.2.3 to 7.2.4

* youdaonote: Remove protocol from verified stanza

- According to Homebrew/brew#14717 it's wrong
  to have the protocol in the "verified" part of a Cask URL. So there's
  now an autocorrecting RuboCop for it at
  Homebrew/brew#14886. This fixes the singular
  offense.

---------

Co-authored-by: Issy Long <me@issyl0.co.uk>
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@issyl0 issyl0

Labels
features New features good first issue A good issue for your first contribution to Homebrew/brew in progress Maintainers are working on this outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rubocops/cask: Disallow protocol in cask URL verified stanza issyl0/brew
3 participants
@issyl0 @SMillerDev @miccal