Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push latest tag for bottles #17837

Closed
1 task done
justenstall opened this issue Jul 23, 2024 · 3 comments
Closed
1 task done

Push latest tag for bottles #17837

justenstall opened this issue Jul 23, 2024 · 3 comments
Labels
features New features

Comments

@justenstall
Copy link

Verification

Provide a detailed description of the proposed feature

Push latest tag to the homebrew/core/<formula> repository when a new bottle version is created, referencing the new image index.

What is the motivation for the feature?

If the current version of the bottle is tagged latest, the current bottle version can be determined without first downloading an updated formula index.

It is standard practice to create a latest tag when pushing a new release image to a container registry.

How will the feature be relevant to at least 90% of Homebrew users?

This is a step towards being able to install the latest version of a formula without an auto-update or running brew update.

What alternatives to the feature have been considered?

Not implementing the feature.

@MikeMcQuaid
Copy link
Member

Thanks for opening @justenstall!

My concern in this case is: how does the consumer validate the checksum of the bottle that is to be downloaded?

@justenstall
Copy link
Author

Thanks for opening @justenstall!

No problem :)

My concern in this case is: how does the consumer validate the checksum of the bottle that is to be downloaded?

The checksum of the bottle file is its digest in the container registry, so if the latest tag was used for resolving the file, the digest can be used to verify the file.

The registry's tags aren't currently used to resolve the file, but if they were in the future, then signing the artifacts in the registry would replicate the security guarantees of the signed API JSON (same as the discussion on #17838).

@MikeMcQuaid
Copy link
Member

The registry's tags aren't currently used to resolve the file, but if they were in the future, then signing the artifacts in the registry would replicate the security guarantees of the signed API JSON (same as the discussion on #17838).

Gotcha. I'm going to close this issue out and fold discussion into there as this functionality would/should be blocked on having similar signing guarantees.

@MikeMcQuaid MikeMcQuaid closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features New features
Projects
None yet
Development

No branches or pull requests

2 participants