Zsh completion shows "deprecated command" warning when completing installed casks

[smancill]

Bug report

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

• ran brew update and can still reproduce the problem?
• ran brew doctor, fixed all issues and can still reproduce the problem?
• ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

Use Zsh tab completion when uninstalling a cask.

What happened (include command output)

The completion shows the warning about deprecated command brew cask list after pressing tab.

$ brew cask uninstall Warning: Calling brew cask list is deprecated! Use brew list --cask instead.

What you expected to happen

Not show any warning.

Step-by-step reproduction instructions (by running brew commands)

Press tab to autocomplete installed casks using Zsh.

Output of brew config and brew doctor commands

Doesn't apply.

---

Here is the line in _brew_cask that is still using brew cask list to get the list of all installed casks.

brew/completions/zsh/_brew_cask

Line 35 in d0e1595

list=( $(__brew_cask list|sed 's/(!)//') )

That calls:

brew/completions/zsh/_brew_cask

Lines 15 to 17 in d0e1595

	__brew_cask() {
	[ -d "$(brew --repo homebrew/cask)" ] && brew cask $@
	}

[jonchang]

Can you open a pull request to fix this? The code should be in completions/zsh.

[Akylzhan]

I can do this