Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the usage of outdated brew cask list in zsh completion #8650

Merged
merged 2 commits into from Sep 11, 2020
Merged

Replace the usage of outdated brew cask list in zsh completion #8650

merged 2 commits into from Sep 11, 2020

Conversation

Akylzhan
Copy link
Contributor

@Akylzhan Akylzhan commented Sep 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #8640

@Akylzhan Akylzhan changed the title Fix the usage of outdated brew cask list in zsh completion Replace the usage of outdated brew cask list in zsh completion Sep 8, 2020
@MikeMcQuaid
Copy link
Member

Should __brew_cask helper function removed then? It's not used anymore.

Yes, I think so 👍🏻

Also, I wasn't sure what to do about the sed filter, so that's why I didn't create a PR. I guess it is not needed?

If it works without: yeh, can be left as-is.

@Akylzhan
Copy link
Contributor Author

Akylzhan commented Sep 9, 2020

@MikeMcQuaid Should I delete another functions that aren't used? Like _brew_cask_audit, _brew_cask_cat (which is duplicated), and others?

@MikeMcQuaid
Copy link
Member

@Akylzhan yes, please!

@MikeMcQuaid MikeMcQuaid merged commit 36f4739 into Homebrew:master Sep 11, 2020
@MikeMcQuaid
Copy link
Member

Thanks again for your PR @Akylzhan, you rock!

@Akylzhan Akylzhan deleted the patch-1 branch September 11, 2020 11:39
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zsh completion shows "deprecated command" warning when completing installed casks
3 participants