Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicts with: [tap]/[cask] should not tap the missing tap #9125

Closed
2 of 3 tasks
max-ae opened this issue Nov 13, 2020 · 2 comments
Closed
2 of 3 tasks

conflicts with: [tap]/[cask] should not tap the missing tap #9125

max-ae opened this issue Nov 13, 2020 · 2 comments
Labels
bug Reproducible Homebrew/brew bug cask Homebrew Cask outdated PR was locked due to age

Comments

@max-ae
Copy link
Contributor

max-ae commented Nov 13, 2020

Bug report

  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

I ran brew update && brew upgrade. Brew then upgraded the calibre cask. Since Homebrew/homebrew-cask#91929, the cask contains a conflicts with-statement that got triggered now with a calibre version bump.
The conflicts-with references the homebrew/cask-versions tap. Upgrading the cask lead to said tap being also tapped, despite the need for it.

What happened (include command output)

Ran brew upgrade, then homebrew/cask-versions got unnecessarily tapped

Command output

❯ brew upgrade
==> Casks with auto_updates or version :latest will not be upgraded
==> Upgrading 1 outdated package:
calibre 5.4.2 -> 5.5.0
==> Upgrading calibre
==> Tapping homebrew/cask-versions

What you expected to happen

brew upgrade not to tap homebrew/cask-versions

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Nov 13, 2020

I agree that references to other taps should not auto-tap them. CC @homebrew/cask for thoughts.

@vitorgalvao vitorgalvao added bug Reproducible Homebrew/brew bug cask Homebrew Cask labels Nov 20, 2020
@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added stale No recent activity and removed stale No recent activity labels Dec 11, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

4 participants