Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cask requirements. #9403

Merged
merged 1 commit into from Dec 18, 2020
Merged

Deprecate cask requirements. #9403

merged 1 commit into from Dec 18, 2020

Conversation

MikeMcQuaid
Copy link
Member

This probably has to wait until 2.7.0 now and will require a bunch of formula changes/deprecations but we should probably start moving in this direction given we're not installing any of these on our CI any more.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-04 at 13:38:49 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 3, 2020
@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 3, 2020
Closed
@miccal miccal mentioned this pull request Dec 3, 2020
Closed
4 tasks
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 4, 2020
@BrewTestBot
Copy link
Member

Review period ended.

jonchang
jonchang approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeMcQuaid MikeMcQuaid force-pushed the deprecate-cask-requirements branch 5 times, most recently from 08853d2 to 43b0820 Compare December 11, 2020 15:22
This was referenced Dec 14, 2020
Merged
Merged
@MikeMcQuaid
Deprecate cask requirements.
87dd13a 
This probably has to wait until 2.7.0 now and will require a bunch of
formula changes/deprecations but we should probably start moving in this
direction given we're not installing any of these on our CI any more.
@MikeMcQuaid MikeMcQuaid removed the request for review from iMichka December 16, 2020 09:00
@MikeMcQuaid MikeMcQuaid merged commit 010ae37 into Homebrew:master Dec 18, 2020
@MikeMcQuaid MikeMcQuaid deleted the deprecate-cask-requirements branch December 18, 2020 12:15
@tlk
Copy link
Contributor

tlk commented Dec 18, 2020

Hi there, any advice on what to use instead of depends_on :x11 in formulas?

@MikeMcQuaid
Copy link
Member Author

@tlk Sure! You'll need to replace with the specific X11 formulae that are used e.g. depends_on "xorgproto". Check out some of the related homebrew/core PRs for details.

@tlk
Copy link
Contributor

tlk commented Dec 18, 2020

@MikeMcQuaid Thanks! It looks like depends_on :x11 could be replaced with depends_on "libx11" in my case.

If this is a recommended replacement for :x11 perhaps this could be reflected in the Formula Cookbook?

@MikeMcQuaid
Copy link
Member Author

If this is a recommended replacement for :x11 perhaps this could be reflected in the Formula Cookbook?

It's not a simple replacement, it depends on what the formula is using (hence the more vague recommendation)

@scpeters
Copy link
Member

When I saw #9052, I assumed requirements would still be allowed in 3rd-party taps, but I guess not. I'll try migrating ours now.

Also a note from Homebrew/homebrew-core#64166 that may cause some issues:

  • "formulae that need to create or interact with an x11 GUI element might not work as not all components that exist in XQuartz.app have been ported over to our brewed versions. The missing X library (e.g. apple-wm) will need to be added as a new formula."

@scpeters scpeters mentioned this pull request Dec 18, 2020
Closed
@tlk tlk mentioned this pull request Dec 19, 2020
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 19, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjackman sjackman sjackman left review comments

@iMichka iMichka iMichka left review comments

@jonchang jonchang jonchang approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MikeMcQuaid @BrewTestBot @tlk @scpeters @jonchang @sjackman @iMichka